- May 22, 2011
-
-
Paul Gortmaker authored
After discovering that wide use of prefetch on modern CPUs could be a net loss instead of a win, net drivers which were relying on the implicit inclusion of prefetch.h via the list headers showed up in the resulting cleanup fallout. Give them an explicit include via the following $0.02 script. ========================================= #!/bin/bash MANUAL="" for i in `git grep -l 'prefetch(.*)' .` ; do grep -q '<linux/prefetch.h>' $i if [ $? = 0 ] ; then continue fi ( echo '?^#include <linux/?a' echo '#include <linux/prefetch.h>' echo . echo w echo q ) | ed -s $i > /dev/null 2>&1 if [ $? != 0 ]; then echo $i needs manual fixup MANUAL="$i $MANUAL" fi done echo ------------------- 8\<---------------------- echo vi $MANUAL ========================================= Signed-off-by:
Paul <paul.gortmaker@windriver.com> [ Fixed up some incorrect #include placements, and added some non-network drivers and the fib_trie.c case - Linus ] Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Paul Gortmaker authored
After discovering that wide use of prefetch on modern CPUs could be a net loss instead of a win, net drivers which were relying on the implicit inclusion of prefetch.h via the list headers showed up in the resulting cleanup fallout. Give them an explicit include via the following $0.02 script. ========================================= #!/bin/bash MANUAL="" for i in `git grep -l 'prefetch(.*)' .` ; do grep -q '<linux/prefetch.h>' $i if [ $? = 0 ] ; then continue fi ( echo '?^#include <linux/?a' echo '#include <linux/prefetch.h>' echo . echo w echo q ) | ed -s $i > /dev/null 2>&1 if [ $? != 0 ]; then echo $i needs manual fixup MANUAL="$i $MANUAL" fi done echo ------------------- 8\<---------------------- echo vi $MANUAL ========================================= Signed-off-by:
Paul <paul.gortmaker@windriver.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Apr 29, 2011
-
-
David Decotigny authored
This updates the network drivers so that they don't access the ethtool_cmd::speed field directly, but use ethtool_cmd_speed() instead. For most of the drivers, these changes are purely cosmetic and don't fix any problem, such as for those 1GbE/10GbE drivers that indirectly call their own ethtool get_settings()/mii_ethtool_gset(). The changes are meant to enforce code consistency and provide robustness with future larger throughputs, at the expense of a few CPU cycles for each ethtool operation. All drivers compiled with make allyesconfig ion x86_64 have been updated. Tested: make allyesconfig on x86_64 + e1000e/bnx2x work Signed-off-by:
David Decotigny <decot@google.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Apr 07, 2011
-
-
Michał Mirosław authored
As the driver uses GRO and not LRO, LRO settings are ignored anyway and are removed here to avoid confusion. Signed-off-by:
Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Mar 30, 2011
-
-
Roopa Prabhu authored
Current enic code only supports ASSOCIATE and DISASSOCIATE port profile operations. This patch adds enic support for port profile PORT_REQUEST_PREASSOCIATE_RR operation. The VIC adapter (8021qbh) is capable of handling port profile requests done in two steps namely PREASSOCIATE_RR and ASSOCIATE today. The motivation to support PREASSOCIATE_RR comes mainly from its use as an optimization during VM migration ie, to do resource reservation on destination host before resources on source host are released. PREASSOCIATE_RR is a VDP operation and according to the latest at IEEE, 8021qbh will also need to support VDP commands. In addition to handling the new PORT_REQUEST_PREASSOCIATE_RR operation this patch also does the below: - Introduces handlers for PORT_REQUEST operations - Moves most of the port profile handling code to new files enic_pp.[ch] - Uses new fw devcmds for port profile operations Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Feb 28, 2011
-
-
Roopa Prabhu authored
During a port profile disassociate all address registrations for the interface are blown away from the adapter. This patch resets the driver cache of registered address lists to zero after a port profile disassociate. Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Feb 17, 2011
-
-
Vasanthy Kolluri authored
We believe that our earlier patch for supporting multiple hardware receive queues per enic device requires more internal testing. At this point, we think that it's best to disable the use of multiple receive queues. The current patch provides an effective means for the same. Also, we continue to disallow multiple hardware transmit queues per device. But change the way we enforce this in order to maintain consistency with the way receive queues are handled. Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
Danny Guo <dannguo@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
Danny Guo <dannguo@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
During a device reset, clear the counter for the no. of unicast addresses registered. Also, rename the routines that update unicast and multicast address lists. Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
Danny Guo <dannguo@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Feb 07, 2011
-
-
Vasanthy Kolluri authored
Remove support for an older version (A1) of hardware Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Firmware requires CMD_IG_VLAN_REWRITE_MODE be issued before a CMD_INIT. Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Organize the wrapper routines for firmware devcmds into a separate file. Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Roopa Prabhu authored
This patch removes VM mac address registration and deregistration code during port profile set operation. We can delay mac address registration until enic_open. Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Jan 20, 2011
-
-
Roopa Prabhu authored
enic_get_vf_port returns port profile operation status only if ENIC_SET_APPLIED flag is set. A recent rework of enic_set_port_profile added code to reset this flag on disassociate. As a result of which a client calling enic_get_vf_port to get the status of port profile disassociate will always get a return value of ENODATA. This patch renames ENIC_SET_APPLIED to more appropriate ENIC_PORT_REQUEST_APPLIED and reverts back the recent change so that the flag is set both at associate and disassociate of a port profile. Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Dec 16, 2010
-
-
Michał Mirosław authored
Some drivers are using skb_transport_offset(skb) instead of skb->csum_start for NETIF_F_HW_CSUM offload. This does not matter now, but if someone implements checksumming of encapsulated packets then this will break silently. TSO output paths are left as they are, since they are for IP+TCP only (might be worth converting though). Signed-off-by:
Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Dec 12, 2010
-
-
Tejun Heo authored
flush_scheduled_work() is on its way out. This patch contains simple conversions to replace flush_scheduled_work() usage with direct cancels and flushes. Directly cancel the used works on driver detach and flush them in other cases. The conversions are mostly straight forward and the only dangers are, * Forgetting to cancel/flush one or more used works. * Cancelling when a work should be flushed (ie. the work must be executed once scheduled whether the driver is detaching or not). I've gone over the changes multiple times but it would be much appreciated if you can review with the above points in mind. Signed-off-by:
Tejun Heo <tj@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jay Cliburn <jcliburn@gmail.com> Cc: Michael Chan <mchan@broadcom.com> Cc: Divy Le Ray <divy@chelsio.com> Cc: e1000-devel@lists.sourceforge.net Cc: Vasanthy Kolluri <vkolluri@cisco.com> Cc: Samuel Ortiz <samuel@sortiz.org> Cc: Lennert Buytenhek <buytenh@wantstofly.org> Cc: Andrew Gallatin <gallatin@myri.com> Cc: Francois Romieu <romieu@fr.zoreil.com> Cc: Ramkrishna Vepa <ramkrishna.vepa@exar.com> Cc: Matt Carlson <mcarlson@broadcom.com> Cc: David Brownell <dbrownell@users.sourceforge.net> Cc: Shreyas Bhatewara <sbhatewara@vmware.com> Cc: netdev@vger.kernel.org
-
- Dec 10, 2010
-
-
Roopa Prabhu authored
Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Roopa Prabhu authored
This patch adds support in enic 802.1Qbh port profile provisioning code to use the mac address set by IFLA_VF_MAC. For now we handle this mac as a special case for a VM mac address sent to us by libvirt. The VM mac address is sent to the switch along with the rest of the port profile provisioning data. This patch also adds calls to register and deregister the mac address during port profile association/deassociation. Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Roopa Prabhu authored
This patch implements the ndo_set_vf_mac netdev operation for enic dynamic devices. It treats the mac address set by IFLA_VF_MAC as a special case to use it in the port profile provisioning data. Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Roopa Prabhu authored
Add ndo_set_rx_mode support to register unicast and multicast address filters for enic devices Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
Christian Benvenuti <benve@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Pass reference to napi instead of enic device to the isr that services receive queue. Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Nov 15, 2010
-
-
Vasanthy Kolluri authored
Fix data type of argument passed to pci_alloc_consistent and pci_free_consistent routines. Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Oct 21, 2010
-
-
Jesse Gross authored
Many (but not all) drivers check to see whether there is a vlan group configured before using a tag stored in the skb. There's not much point in this check since it just throws away data that should only be present in the expected circumstances. However, it will soon be legal and expected to get a vlan tag when no vlan group is configured, so remove this check from all drivers to avoid dropping the tags. Signed-off-by:
Jesse Gross <jesse@nicira.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Fix a log message Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Replace no wait CMD_ENABLE firmware devcmd with CMD_ENABLE_WAIT Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Let the firmware know about the mac address set by the user using ndo_set_mac_address Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Add support for multiple hardware receive queues. The ingress traffic is hashed into one of the receive queues based on IP or TCP or both headers. The max no. of receive queues supported is 8. Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Oct 01, 2010
-
-
Vasanthy Kolluri authored
Make functions used locally in a file as static Signed-off-by:
Stephen Hemminger <shemminger@vyatta.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David Wang <dwang2@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Aug 17, 2010
-
-
Roopa Prabhu authored
Remove function enic_dev_stats_clear and its reference in enic device init code. Firmware clears device stats on device open. So, no need for the driver to do it again. Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Roopa Prabhu authored
This patch implements the ndo_set_mac_address netdev operation for an enic device Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Aug 04, 2010
-
-
Joe Perches authored
Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Jun 30, 2010
-
-
Ben Hutchings authored
ethtool_op_set_flags() does not check for unsupported flags, and has no way of doing so. This means it is not suitable for use as a default implementation of ethtool_ops::set_flags. Add a 'supported' parameter specifying the flags that the driver and hardware support, validate the requested flags against this, and change all current callers to pass this parameter. Change some other trivial implementations of ethtool_ops::set_flags to call ethtool_op_set_flags(). Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Reviewed-by:
Stanislaw Gruszka <sgruszka@redhat.com> Acked-by:
Jeff Garzik <jgarzik@redhat.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Jun 25, 2010
-
-
Vasanthy Kolluri authored
1) Update copyright 2) Fix hardware queue descriptor field size CQ_ENET_RQ_DESC_FCOE_SOF_BITS 3) Include rtnetlink.h instead of if_link.h 4) Selectively flush writes to interrupt mask register 5) Use pci_enable_device_mem 6) Remove unused variables and header files 7) Fix size mismatch between memory alloc and free operations of a variable 8) Check for non null arguments to vic_provinfo_alloc Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Hardware has the loopback capability to queue the packets transmitted from a device to the receive queue of the same device. enic now supports the loopback capability. Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Replace all printk routines with the (netdev|dev|pr)_<level> macros that provide verbose logs. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
Add wrapper routines that issue devcmds to firmware and ensure that a devcmd lock is held for each devcmd call. Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
The port profile information for a dynamic enic device is set by the upper layers, that are oblivious to the device reset operation. We do not want a reset operation erase the network state of a dynamic enic device as there is no way to set up the port profile information again. Hence a lighter reset operation called hang reset is used. Hang reset, unlike soft reset does not reset the network state and resets the host side state only. Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
The current ingress vlan rewrite mode setting lets the hardware strip off the tag control information of a packet received on native vlan. As a result, the priority bits are also lost. The fix is to change the ingress vlan rewrite mode setting such that the complete tag control information is retained for packets that belong to native vlan. Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Vasanthy Kolluri authored
enic now uses the GRO mechanism instead of LRO to pass skbs to upper layers. Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
Vasanthy Kolluri <vkolluri@cisco.com> Signed-off-by:
Roopa Prabhu <roprabhu@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Jun 02, 2010
-
-
Scott Feldman authored
To make get/set netlink VF_PORT truly symmetrical, we need to keep track of what items are set and only return those items on get. Previously, the driver wasn't differentiating between a set of attr with a NULL string, for example, and not setting the attr at all. We only want to return the NULL string if the attr was actually set with a NULL string. Otherwise, don't return the attr. Signed-off-by:
Scott Feldman <scofeldm@cisco.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-