Skip to content
Snippets Groups Projects
  1. Apr 06, 2011
  2. Mar 28, 2011
    • Stanislaw Gruszka's avatar
      net: fix ethtool->set_flags not intended -EINVAL return value · 673e63c6
      Stanislaw Gruszka authored
      
      After commit d5dbda23 "ethtool: Add
      support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
      and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
      acceleration via ethtool set_flags, always return -EINVAL from that
      function. Fix by returning -EINVAL only if requested features do not
      match current settings and can not be changed by driver.
      
      Change any driver that define ethtool->set_flags to use
      ethtool_invalid_flags() to avoid similar problems in the future
      (also on drivers that do not have the problem).
      
      Tested with modified (to reproduce this bug) myri10ge driver.
      
      Cc: stable@kernel.org # 2.6.37+
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      673e63c6
  3. Feb 23, 2011
  4. Jan 10, 2011
  5. Dec 21, 2010
  6. Dec 17, 2010
  7. Dec 03, 2010
  8. Nov 28, 2010
  9. Nov 27, 2010
  10. Nov 17, 2010
  11. Oct 31, 2010
  12. Oct 27, 2010
  13. Oct 21, 2010
  14. Oct 18, 2010
  15. Oct 08, 2010
Loading