Commit 13b93ed9 authored by Sony Chacko's avatar Sony Chacko Committed by David S. Miller
Browse files

qlcnic: fix ethtool diagnostics test

IRQ diag test was getting executed only when both register test
and link test passed. The test should get executed if ETH_TEST_FL_OFFLINE
flag is set.
Signed-off-by: default avatarSony Chacko <>
Signed-off-by: default avatarAmit Kumar Salecha <>
Signed-off-by: default avatarDavid S. Miller <>
parent 0e5f20b6
......@@ -672,7 +672,7 @@ qlcnic_diag_test(struct net_device *dev, struct ethtool_test *eth_test,
if (data[1])
eth_test->flags |= ETH_TEST_FL_FAILED;
if (eth_test->flags == ETH_TEST_FL_OFFLINE) {
if (eth_test->flags & ETH_TEST_FL_OFFLINE) {
data[2] = qlcnic_irq_test(dev);
if (data[2])
eth_test->flags |= ETH_TEST_FL_FAILED;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment