• Stefan Weil's avatar
    qga: Fix compiler warnings (missing format attribute, wrong format strings) · d607a523
    Stefan Weil authored
    gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
    
      CC    qga/commands.o
    qga/commands.c: In function ‘slog’:
    qga/commands.c:28:5: error:
     function might be possible candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
         g_logv("syslog", G_LOG_LEVEL_INFO, fmt, ap);
         ^
    
    gcc 4.8.2 reports this warning when slog is declared with the
    gnu_printf format attribute:
    
    qga/commands-posix.c: In function ‘qmp_guest_file_open’:
    qga/commands-posix.c:404:5: warning:
     format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘int64_t’ [-Wformat=]
         slog("guest-file-open, handle: %d", handle);
         ^
    
    On 32 bit hosts there are three more warnings which are also fixed here.
    Signed-off-by: default avatarStefan Weil <sw@weilnetz.de>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    d607a523
commands-posix.c 39.4 KB