Skip to content
  • Stefan Hajnoczi's avatar
    qom: Make QOM link property unref optional · 9561fda8
    Stefan Hajnoczi authored
    
    
    Some object_property_add_link() callers expect property deletion to
    unref the link property object.  Other callers expect to manage the
    refcount themselves.  The former are currently broken and therefore leak
    the link property object.
    
    This patch adds a flags argument to object_property_add_link() so the
    caller can specify which refcount behavior they require.  The new
    OBJ_PROP_LINK_UNREF_ON_RELEASE flag causes the link pointer to be
    unreferenced when the property is deleted.
    
    This fixes refcount leaks in qdev.c, xilinx_axidma.c, xilinx_axienet.c,
    s390-virtio-bus.c, virtio-pci.c, virtio-rng.c, and ui/console.c.
    
    Rationale for refcount behavior:
    
     * hw/core/qdev.c
       - bus children are explicitly unreferenced, don't interfere
       - parent_bus is essentially a read-only property that doesn't hold a
         refcount, don't unref
       - hotplug_handler is leaked, do unref
    
     * hw/dma/xilinx_axidma.c
       - rx stream "dma" links are set using set_link, therefore they
         need unref
       - tx streams are set using set_link, therefore they need unref
    
     * hw/net/xilinx_axienet.c
       - same reasoning as hw/dma/xilinx_axidma.c
    
     * hw/pcmcia/pxa2xx.c
       - pxa2xx bypasses set_link and therefore does not use refcounts
    
     * hw/s390x/s390-virtio-bus.c
     * hw/virtio/virtio-pci.c
     * hw/virtio/virtio-rng.c
     * ui/console.c
       - set_link is used and there is no explicit unref, do unref
    
    Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
    Cc: Alexander Graf <agraf@suse.de>
    Cc: Anthony Liguori <aliguori@amazon.com>
    Cc: "Michael S. Tsirkin" <mst@redhat.com>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
    9561fda8