• Markus Armbruster's avatar
    qapi: Replace start_optional()/end_optional() by optional() · e2cd0f4f
    Markus Armbruster authored
    Semantics of end_optional() differ subtly from the other end_FOO()
    callbacks: when start_FOO() succeeds, the matching end_FOO() gets
    called regardless of what happens in between.  end_optional() gets
    called only when everything in between succeeds as well.  Entirely
    undocumented, like all of the visitor API.
    The only user of Visitor Callback end_optional() never did anything,
    and was removed in commit 9f9ab465.
    I'm about to clean up error handling in the generated visitor code,
    and end_optional() is in my way.  No users mean no test cases, and
    making non-trivial cleanup transformations without test cases doesn't
    strike me as a good idea.
    Drop end_optional(), and rename start_optional() to optional().  We
    can always go back to a pair of callbacks when we have an actual need.
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
qmp-input-visitor.c 8.9 KB