• Markus Armbruster's avatar
    qom: Clean up fragile use of error_is_set() in set() methods · 65cd9064
    Markus Armbruster authored
    Using error_is_set(ERRP) to find out whether a function failed is
    either wrong, fragile, or unnecessarily opaque.  It's wrong when ERRP
    may be null, because errors go undetected when it is.  It's fragile
    when proving ERRP non-null involves a non-local argument.  Else, it's
    unnecessarily opaque (see commit 84d18f06).
    
    I guess the error_is_set(errp) in the ObjectProperty set() methods are
    merely fragile right now, because I can't find a call chain that
    passes a null errp argument.
    
    Make the code more robust and more obviously correct: receive the
    error in a local variable, then propagate it through the parameter.
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
    65cd9064
tpm.c 4.35 KB