Skip to content
  • Stefan Hajnoczi's avatar
    qemu-img: always goto out in img_snapshot() error paths · 40ed35a3
    Stefan Hajnoczi authored
    The out label has the qemu_progress_end() and other cleanup calls.
    Always goto out in error paths so the cleanup happens.  These error
    paths now return 1 instead of -1.
    
    Note that bdrv_unref(NULL) is safe.  We just need to initialize bs to
    NULL at the top of the function.
    
    We can now remove the obsolete bs_old_backing = NULL and bs_new_backing
    = NULL for safe mode.  Originally it was necessary in commit 3e85c6fd
    ("qemu-img rebase") but became useless in commit c2abccec
    
     ("qemu-img:
    avoid calling exit(1) to release resources properly") because the
    variables are already initialized during declaration.
    
    Reported-by: default avatarJohn Snow <jsnow@redhat.com>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
    40ed35a3