Skip to content
  • Michael S. Tsirkin's avatar
    virtio-net: fix guest-triggerable buffer overrun · edc24385
    Michael S. Tsirkin authored
    
    
    When VM guest programs multicast addresses for
    a virtio net card, it supplies a 32 bit
    entries counter for the number of addresses.
    These addresses are read into tail portion of
    a fixed macs array which has size MAC_TABLE_ENTRIES,
    at offset equal to in_use.
    
    To avoid overflow of this array by guest, qemu attempts
    to test the size as follows:
    -    if (in_use + mac_data.entries <= MAC_TABLE_ENTRIES) {
    
    however, as mac_data.entries is uint32_t, this sum
    can overflow, e.g. if in_use is 1 and mac_data.entries
    is 0xffffffff then in_use + mac_data.entries will be 0.
    
    Qemu will then read guest supplied buffer into this
    memory, overflowing buffer on heap.
    
    CVE-2014-0150
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Message-id: 1397218574-25058-1-git-send-email-mst@redhat.com
    Reviewed-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
    Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
    edc24385