Skip to content
  • Stuart Brady's avatar
    Clean up definition of MAX_OPC_PARAM · 4d0e4ac7
    Stuart Brady authored
    
    
    MAX_OPC_PARAM is intended to refer to the maximum number of entries used
    in gen_opparam_buf[] for any single helper call.  It is currently defined
    as 10, but for 32-bit archs, the correct value (with a maximum for four
    helper arguments) is 14, and for 64-bit archs, only 9 entries are needed.
    
    tcg_gen_callN() fills four entries with the function address, flags,
    number of args, etc. and on 32-bit archs uses a further two entries per
    argument (with a maximum of four helper arguments), plus two more for the
    return value.  On 64-bit archs, only half as many entries are used for the
    args and the return value.
    
    In reality, TBs tend not to consist purely of helper calls exceeding the
    stated 10 gen_opparam_buf[] entries, so this would never actually be a
    problem on 32-bit archs, but the definition is still rather confusing.
    
    Signed-off-by: default avatarStuart Brady <sdb@zubnet.me.uk>
    Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
    4d0e4ac7