• Dan Carpenter's avatar
    ide: silence some underflow warnings · 0860bf94
    Dan Carpenter authored
    Back in the day we used to just say this code was root only so it was
    ok that the bounds checking was sloppy.  These days it annoys static
    checkers so we fix it.
    In the original code "c > INT_MAX" was never true since "c" was an int.
    I am not sure what was intended so I left it alone.  But because I made
    "c" unsigned it means we don't have a warning any more.
    The second warning is that we cap "i" but allow negatives leading to an
    underflow of the ide_disks_chs[] array.  The third set of warnings is
    because these values come from the user and we cap most of the upper
    bounds but allow negative values.  Negative cylinders doesn't make
    drivers/ide/ide.c:262 ide_set_disk_chs() warn: impossible condition '(c > ((~0 >> 1))) => (s32min-s32max > s32max)'
    drivers/ide/ide.c:270 ide_set_disk_chs() warn: check 'ide_disks_chs[i]' for negative offsets 'i' = s32min.  extra = 's32min-19'
    drivers/ide/ide.c:271 ide_set_disk_chs() warn: no lower bound on 'h'
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>