Skip to content
  • Dan Carpenter's avatar
    ISDN: pcbit: off by one bugs in pcbit_set_msn() · 7bcc6738
    Dan Carpenter authored
    
    
    1) We don't allocate enough space for the NUL terminator so we end up
       corrupting one character beyond the end of the buffer.
    
    2) The "len - 1" should just be "len".  The code is trying to copy a
       word from a buffer up to a comma or the last word in the buffer.
       Say you have the buffer, "foo,bar,baz", then this code truncates the
       last letter off each word so you get "fo", "ba", and "ba".  You would
       hope this kind of bug would get noticed in testing...
    
       I'm not very familiar with this code and I can't test it, but I think
       we should copy the final character.
    
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7bcc6738