Skip to content
  • Paulo Marques's avatar
    kallsyms should prefer non weak symbols · f2df3f65
    Paulo Marques authored
    
    
    When resolving symbol names from addresses with aliased symbol names,
    kallsyms_lookup always returns the first symbol, even if it is a weak
    symbol.
    
    This patch changes this by sorting the symbols with the weak symbols last
    before feeding them to the kernel.  This way the kernel runtime isn't
    changed at all, only the kallsyms build system is changed.
    
    Another side effect is that the symbols get sorted by address, too.  So,
    even if future binutils version have some bug in "nm" that makes it fail to
    correctly sort symbols by address, the kernel won't be affected by this.
    
    Mathieu says:
    
      I created a module in LTTng that uses kallsyms to get the symbol
      corresponding to a specific system call address.  Unfortunately, all the
      unimplemented syscalls were all referring to the (same) weak symbol
      identifying an unrelated system call rather that sys_ni (or whatever
      non-weak symbol would be expected).  Kallsyms was dumbly returning the first
      symbol that matched.
    
      This patch makes sure kallsyms returns the non-weak symbol when there is
      one, which seems to be the expected result.
    
    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    Looks-great-to: Rusty Russell <rusty@rustcorp.com.au>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f2df3f65