Skip to content
  • Andrea Arcangeli's avatar
    mm: compaction: don't depend on HUGETLB_PAGE · 33a93877
    Andrea Arcangeli authored
    Commit 5d689240
    
     ("thp: select CONFIG_COMPACTION if TRANSPARENT_HUGEPAGE
    enabled") causes this warning during the configuration process:
    
      warning: (TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet
      direct dependencies (EXPERIMENTAL && HUGETLB_PAGE && MMU)
    
    COMPACTION doesn't depend on HUGETLB_PAGE, it doesn't depend on THP
    either, it is also useful for regular alloc_pages(order > 0) including
    the very kernel stack during fork (THREAD_ORDER = 1).  It's always
    better to enable COMPACTION.
    
    The warning should be an error because we would end up with MIGRATION
    not selected, and COMPACTION wouldn't work without migration (despite it
    seems to build with an inline migrate_pages returning -ENOSYS).
    
    I'd also like to remove EXPERIMENTAL: compaction has been in the kernel
    for some releases (for full safety the default remains disabled which I
    think is enough).
    
    Signed-off-by: default avatarAndrea Arcangeli <aarcange@redhat.com>
    Reported-by: default avatarLuca Tettamanti <kronos.it@gmail.com>
    Tested-by: default avatarLuca Tettamanti <kronos.it@gmail.com>
    Cc: Mel Gorman <mel@csn.ul.ie>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    33a93877