• Michael Schmitz's avatar
    m68k/atari - ide: do not register interrupt if host->get_lock is set · a259d532
    Michael Schmitz authored
    On m68k, host->get_lock is used to both lock and register the interrupt
    that the IDE host shares with other device drivers. Registering the
    IDE interrupt handler in ide-probe.c results in duplicating the
    interrupt registered (once via host->get lock, and also via init_irq()),
    and may result in IDE accepting interrupts even when another driver has
    locked the interrupt hardware. This opens the whole locking scheme up
    to races.
    
    host->get_lock is set on m68k only, so other drivers' behaviour is not
    changed.
    Signed-off-by: 's avatarMichael Schmitz <schmitz@debian.org>
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: linux-ide@vger.kernel.org
    Signed-off-by: 's avatarDavid S. Miller <davem@davemloft.net>
    a259d532
ide-probe.c 37.5 KB