• Luis R. Rodriguez's avatar
    firmware loader: inform direct failure when udev loader is disabled · c868edf4
    Luis R. Rodriguez authored
    Now that the udev firmware loader is optional request_firmware()
    will not provide any information on the kernel ring buffer if
    direct firmware loading failed and udev firmware loading is disabled.
    If no information is needed request_firmware_direct() should be used
    for optional firmware, at which point drivers can take on the onus
    over informing of any failures, if udev firmware loading is disabled
    though we should at the very least provide some sort of information
    as when the udev loader was enabled by default back in the days.
    
    With this change with a simple firmware load test module [0]:
    
    Example output without FW_LOADER_USER_HELPER_FALLBACK
    
    platform fake-dev.0: Direct firmware load for fake.bin failed
    with error -2
    
    Example with FW_LOADER_USER_HELPER_FALLBACK
    
    platform fake-dev.0: Direct firmware load for fake.bin failed with error -2
    platform fake-dev.0: Falling back to user helper
    
    Without this change without FW_LOADER_USER_HELPER_FALLBACK we
    get no output logged upon failure.
    
    Cc: Tom Gundersen <teg@jklm.no>
    Cc: Ming Lei <ming.lei@canonical.com>
    Cc: Abhay Salunke <Abhay_Salunke@dell.com>
    Cc: Stefan Roese <sr@denx.de>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Kay Sievers <kay@vrfy.org>
    Signed-off-by: default avatarLuis R. Rodriguez <mcgrof@suse.com>
    Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    c868edf4
firmware.h 2.01 KB