• Michal Hocko's avatar
    mm, aout: handle vm_brk failures · 864778b1
    Michal Hocko authored
    vm_brk is allowed to fail but load_aout_binary simply ignores the error
    and happily continues.  I haven't noticed any problem from that in real
    life but later patches will make the failure more likely because vm_brk
    will become killable (resp.  mmap_sem for write waiting will become
    killable) so we should be more careful now.
    The error handling should be quite straightforward because there are
    calls to vm_mmap which check the error properly already.  The only
    notable exception is set_brk which is called after beyond_if label.  But
    nothing indicates that we cannot move it above set_binfmt as the two do
    not depend on each other and fail before we do set_binfmt and alter
    reference counting.
    Signed-off-by: default avatarMichal Hocko <mhocko@suse.com>
    Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Alexander Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
binfmt_aout.c 10.9 KB