Skip to content
  • Sedat Dilek's avatar
    tools/lib/lockdep: Fix unsupported 'basename -s' in run_tests.sh · a189c017
    Sedat Dilek authored
    Here on Ubuntu/precise I have GNU/coreutils v8.13 installed
    where 'basename -s' is not supported.
    
    The result is that run_tests.sh is not done properly.
    
    How to reproduce:
    
      $ cd $BUILD_DIR
      $ LC_ALL=C make -C tools/ liblockdep
      $ cd tools/lib/lockdep/
    
        $ LC_ALL=C ./run_tests.sh
      basename: invalid option -- 's'
      Try `basename --help' for more information.
      ... timeout: failed to run command `./tests/': Permission denied
      FAILED!
      rm: cannot remove `tests/': Is a directory
    
    Due to unsupported basename the tests programs are not generated
    and cannot be removed.
    
    Fix this by doing a compatible basename invocation and check for
    the existence of generated tests programs.
    
    For more details see this LKML thread:
    
      http://marc.info/?t=145906667300001&r=1&w=2
    
    
    
    Signed-off-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
    Cc: Boqun Feng <boqun.feng@gmail.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sasha Levin <sasha.levin@oracle.com> (maintainer:LIBLOCKDEP)
    Cc: Shuah Khan <shuahkh@osg.samsung.com>
    Cc: Theodore Ts'o <tytso@mit.edu>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
    Link: http://lkml.kernel.org/r/1459326169-7009-1-git-send-email-sedat.dilek@gmail.com
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    a189c017