• David Howells's avatar
    Make do_execve() take a const filename pointer · d7627467
    David Howells authored
    Make do_execve() take a const filename pointer so that kernel_execve() compiles
    correctly on ARM:
    arch/arm/kernel/sys_arm.c:88: warning: passing argument 1 of 'do_execve' discards qualifiers from pointer target type
    This also requires the argv and envp arguments to be consted twice, once for
    the pointer array and once for the strings the array points to.  This is
    because do_execve() passes a pointer to the filename (now const) to
    copy_strings_kernel().  A simpler alternative would be to cast the filename
    pointer in do_execve() when it's passed to copy_strings_kernel().
    do_execve() may not change any of the strings it is passed as part of the argv
    or envp lists as they are some of them in .rodata, so marking these strings as
    const should be fine.
    Further kernel_execve() and sys_execve() need to be changed to match.
    This has been test built on x86_64, frv, arm and mips.
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Tested-by: default avatarRalf Baechle <ralf@linux-mips.org>
    Acked-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
kmod.c 11.8 KB