Skip to content
  • Fabio Estevam's avatar
    include/linux/crash_dump.h needs elf.h · 1f536b9e
    Fabio Estevam authored
    Building an ARM target we get the following warnings:
    
      CC      arch/arm/kernel/setup.o
      In file included from arch/arm/kernel/setup.c:39:
      arch/arm/include/asm/elf.h:102:1: warning: "vmcore_elf64_check_arch" redefined
      In file included from arch/arm/kernel/setup.c:24:
      include/linux/crash_dump.h:30:1: warning: this is the location of the previous definition
    
    Quoting Russell King:
    
    "linux/crash_dump.h makes no attempt to include asm/elf.h, but it depends
    on stuff in asm/elf.h to determine how stuff inside this file is defined
    at parse time.
    
    So, if asm/elf.h is included after linux/crash_dump.h or not at all, you
    get a different result from the situation where asm/elf.h is included
    before."
    
    So add elf.h header to crash_dump.h to avoid this problem.
    
    The original discussion about this can be found at:
    http://www.spinics.net/lists/arm-kernel/msg154113.html
    
    
    
    Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
    Cc: Russell King <rmk@arm.linux.org.uk>
    Cc: <stable@vger.kernel.org>	[3.2.1]
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    1f536b9e