• Linus Torvalds's avatar
    Revert "vfs: add lookup_hash() helper" · 20d00ee8
    Linus Torvalds authored
    This reverts commit 3c9fe8cd.
    As Miklos points out in commit c1b2cc1a, the "lookup_hash()" helper
    is now unused, and in fact, with the hash salting changes, since the
    hash of a dentry name now depends on the directory dentry it is in, the
    helper function isn't even really likely to be useful.
    So rather than keep it around in case somebody else might end up finding
    a use for it, let's just remove the helper and not trick people into
    thinking it might be a useful thing.
    For example, I had obviously completely missed how the helper didn't
    follow the normal dentry hashing patterns, and how the hash salting
    patch broke overlayfs.  Things would quietly build and look sane, but
    not work.
    Suggested-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
namei.h 3.35 KB