Skip to content
  • Gobinda Charan Maji's avatar
    sysfs: tightened sysfs permission checks · 28b8d0c8
    Gobinda Charan Maji authored
    
    
    There were some inconsistency in restriction to VERIFY_OCTAL_PERMISSIONS().
    Previously the test was "User perms >= group perms >= other perms". The
    permission field of User, Group or Other consists of three bits. LSB is
    EXECUTE permission, MSB is READ permission and the middle bit is WRITE
    permission. But logically WRITE is "more privileged" than READ.
    
    Say for example, permission value is "0430". Here User has only READ
    permission whereas Group has both WRITE and EXECUTE permission.
    
    So, the checks could be tightened and the tests are separated to
    USER_READABLE >= GROUP_READABLE >= OTHER_READABLE,
    USER_WRITABLE >= GROUP_WRITABLE and OTHER_WRITABLE is not permitted.
    
    Signed-off-by: default avatarGobinda Charan Maji <gobinda.cemk07@gmail.com>
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    28b8d0c8