• David S. Miller's avatar
    Revert "ide: try to use PIO Mode 0 during probe if possible" · 0fb18c47
    David S. Miller authored
    This reverts commit 60293364.
    
    Ok, we really do need to revert this, even with Bart's sis5513.c
    fix in there.
    
    The problem is that several driver's ->set_pio_mode() method
    depends upon the drive->media type being set properly.  Most
    of them use this to enable prefetching, which can only be done
    for disk media.
    
    But the commit being reverted here calls ->set_pio_mode() before
    it's setup.  Actually it considers everything disk because that
    is the default media type set by ide_port_init_devices_data().
    
    The set of drivers that depend upon the media type in their
    ->set_pio_method() are:
    
    drivers/ide/alim15x3.c
    drivers/ide/it8172.c
    drivers/ide/it8213.c
    drivers/ide/pdc202xx_old.c
    drivers/ide/piix.c
    drivers/ide/qd65xx.c
    drivers/ide/sis5513.c
    drivers/ide/slc90e66.c
    
    And it is possible that we could fix this by guarding the prefetching
    and other media dependent setting changes with a test on
    IDE_PFLAG_PROBING in hwif->port_flags, that's simply too risky for
    2.6.32-rcX and -stable.
    Signed-off-by: 's avatarDavid S. Miller <davem@davemloft.net>
    0fb18c47
ide-probe.c 37.7 KB