Skip to content
  • Wang Nan's avatar
    perf record: Rename variable to make code clear · 09fa4f40
    Wang Nan authored
    
    
    record__mmap_read() writes data from ring buffer into perf.data.  'head'
    is maintained by the kernel, points to the last written record.
    'old' is maintained by perf, points to the record read in previous
    round. record__mmap_read() saves data from 'old' to 'head' to
    perf.data.
    
    The names of these variables are not very intutive. In addition,
    when dealing with backward writing ring buffer, the md->prev pointer
    should point to 'head' instead of the last byte it got.
    
    Add 'start' and 'end' pointer to make code clear and set md->prev to
    'head' instead of the moved 'old' pointer. This patch doesn't change
    behavior since:
    
        buf = &data[old & md->mask];
        size = head - old;
        old += size;     <--- Here, old == head
    
    Signed-off-by: default avatarWang Nan <wangnan0@huawei.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Zefan Li <lizefan@huawei.com>
    Cc: pi3orama@163.com
    Link: http://lkml.kernel.org/r/1463987628-163563-4-git-send-email-wangnan0@huawei.com
    
    
    Signed-off-by: default avatarHe Kuang <hekuang@huawei.com>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    09fa4f40