Skip to content
Snippets Groups Projects
  1. Aug 09, 2010
    • Oleg Nesterov's avatar
      sys_personality: remove the bogus checks in sys_personality()->__set_personality() path · 2ee7c922
      Oleg Nesterov authored
      
      Cleanup, no functional changes.
      
      - __set_personality() always changes ->exec_domain/personality, the
        special case when ->exec_domain remains the same buys nothing but
        complicates the code. Unify both cases to simplify the code.
      
      - The -EINVAL check in sys_personality() was never right. If we assume
        that set_personality() can fail we should check the value it returns
        instead of verifying that task->personality was actually changed.
      
        Remove it. Before the previous patch it was possible to hit this case
        due to overflow problems, but this -EINVAL just indicated the kernel
        bug.
      
      OTOH, probably it makes sense to change lookup_exec_domain() to return
      ERR_PTR() instead of default_exec_domain if the search in exec_domains
      list fails, and report this error to the user-space.  But this means
      another user-space change, and we have in-kernel users which need fixes.
      For example, PER_OSF4 falls into PER_MASK for unkown reason and nobody
      cares to register this domain.
      
      Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
      Cc: Wenming Zhang <wezhang@redhat.com>
      Cc: "H. Peter Anvin" <hpa@zytor.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      2ee7c922
  2. Jun 04, 2010
    • Oleg Nesterov's avatar
      sys_personality: change sys_personality() to accept "unsigned int" instead of u_long · 485d5276
      Oleg Nesterov authored
      
      task_struct->pesonality is "unsigned int", but sys_personality() paths use
      "unsigned long pesonality".  This means that every assignment or
      comparison is not right.  In particular, if this argument does not fit
      into "unsigned int" __set_personality() changes the caller's personality
      and then sys_personality() returns -EINVAL.
      
      Turn this argument into "unsigned int" and avoid overflows.  Obviously,
      this is the user-visible change, we just ignore the upper bits.  But this
      can't break the sane application.
      
      There is another thing which can confuse the poorly written applications.
      User-space thinks that this syscall returns int, not long.  This means
      that the returned value can be negative and look like the error code.  But
      note that libc won't be confused and thus errno won't be set, and with
      this patch the user-space can never get -1 unless sys_personality() really
      fails.  And, most importantly, the negative RET != -1 is only possible if
      that app previously called personality(RET).
      
      Pointed-out-by: default avatarWenming Zhang <wezhang@redhat.com>
      Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
      Cc: "H. Peter Anvin" <hpa@zytor.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      485d5276
  3. Mar 31, 2009
  4. Jan 14, 2009
  5. Oct 23, 2008
  6. Jul 26, 2008
  7. Jul 22, 2008
  8. Oct 18, 2007
  9. Jun 30, 2006
  10. Mar 24, 2006
  11. Apr 16, 2005
    • Linus Torvalds's avatar
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds authored
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      
      Let it rip!
Loading