Skip to content
Snippets Groups Projects
  1. Jul 26, 2011
  2. Jul 12, 2011
  3. Jul 08, 2011
  4. Jun 06, 2011
  5. May 18, 2011
    • Grant Likely's avatar
      drivercore: revert addition of of_match to struct device · b1608d69
      Grant Likely authored
      
      Commit b826291c, "drivercore/dt: add a match table pointer to struct
      device" added an of_match pointer to struct device to cache the
      of_match_table entry discovered at driver match time.  This was unsafe
      because matching is not an atomic operation with probing a driver.  If
      two or more drivers are attempted to be matched to a driver at the
      same time, then the cached matching entry pointer could get
      overwritten.
      
      This patch reverts the of_match cache pointer and reworks all users to
      call of_match_device() directly instead.
      
      Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
      b1608d69
  6. Apr 17, 2011
  7. Apr 12, 2011
    • David S. Miller's avatar
      atm: iphase: Fix set-but-not-used warnings. · 24743537
      David S. Miller authored
      
      The "iavcc" and "iadev" cases are obvious.
      
      The intr_status and frmr_intr cases are reading a register to clear
      the chip status.  This driver is pretty old and creaky, and uses
      volatile pointer dereferences to do register I/O when it should be
      using readl() and friends.  However that it outside of the scope of
      these changes.
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      24743537
  8. Mar 31, 2011
  9. Mar 30, 2011
  10. Feb 28, 2011
  11. Feb 13, 2011
  12. Feb 02, 2011
  13. Jan 21, 2011
  14. Jan 09, 2011
  15. Dec 31, 2010
  16. Dec 10, 2010
  17. Dec 08, 2010
  18. Nov 18, 2010
    • David S. Miller's avatar
      atm: fore200e: Fix build warning. · 30dfe2c0
      David S. Miller authored
      
      GCC (rightfully) complains that:
      
      drivers/atm/fore200e.c:614:5: warning: operation on 'cmdq->head' may be undefined
      
      This is due to the FORE200E_NEXT_ENTRY macro, which essentially
      evaluates to:
      
      	i = ++i % m
      
      Make it what's explicitly intended here which is:
      
      	i = (i + 1) % m
      
      and the warning goes away.
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      30dfe2c0
  19. Nov 08, 2010
  20. Nov 01, 2010
  21. Oct 26, 2010
  22. Oct 21, 2010
  23. Oct 18, 2010
  24. Oct 11, 2010
  25. Oct 03, 2010
    • Julia Lawall's avatar
      drivers/atm/idt77252.c: Remove unnecessary error check · 1790c228
      Julia Lawall authored
      This code does not call deinit_card(card); in an error case, as done in
      other error-handling code in the same function.  But actually, the called
      function init_sram can only return 0, so there is no need for the error
      check at all.
      
      init_sram is also given a void return type, and its single return statement
      at the end of the function is dropped.
      
      A simplified version of the sematic match that finds this problem is as
      follows: (http://coccinelle.lip6.fr/
      
      )
      
      // <smpl>
      @r exists@
      @r@
      statement S1,S2,S3;
      constant C1,C2,C3;
      @@
      
      *if (...)
       {... S1 return -C1;}
      ...
      *if (...)
       {... when != S1
          return -C2;}
      ...
      *if (...)
       {... S1 return -C3;}
      // </smpl>
      
      Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1790c228
  26. Sep 21, 2010
  27. Sep 06, 2010
  28. Aug 16, 2010
  29. Aug 08, 2010
    • David Woodhouse's avatar
      solos-pci: Fix race condition in tasklet RX handling · 1f6ea6e5
      David Woodhouse authored
      
      We were seeing faults in the solos-pci receive tasklet when packets
      arrived for a VCC which was currently being closed:
      
      [18842.727906] EIP: [<e082f490>] br2684_push+0x19/0x234 [br2684] SS:ESP 0068:dfb89d14 
      
      [18845.090712] [<c13ecff3>] ? do_page_fault+0x0/0x2e1 
      [18845.120042] [<e082f490>] ? br2684_push+0x19/0x234 [br2684] 
      [18845.153530] [<e084fa13>] solos_bh+0x28b/0x7c8 [solos_pci] 
      [18845.186488] [<e084f711>] ? solos_irq+0x2d/0x51 [solos_pci] 
      [18845.219960] [<c100387b>] ? handle_irq+0x3b/0x48 
      [18845.247732] [<c10265cb>] ? irq_exit+0x34/0x57 
      [18845.274437] [<c1025720>] tasklet_action+0x42/0x69 
      [18845.303247] [<c102643f>] __do_softirq+0x8e/0x129 
      [18845.331540] [<c10264ff>] do_softirq+0x25/0x2a 
      [18845.358274] [<c102664c>] _local_bh_enable_ip+0x5e/0x6a 
      [18845.389677] [<c102666d>] local_bh_enable+0xb/0xe 
      [18845.417944] [<e08490a8>] ppp_unregister_channel+0x32/0xbb [ppp_generic] 
      [18845.458193] [<e08731ad>] pppox_unbind_sock+0x18/0x1f [pppox] 
      
      This patch uses an RCU-inspired approach to fix it. In the RX tasklet's
      find_vcc() function we first refuse to use a VCC which already has the
      ATM_VF_READY bit cleared. And in the VCC close function, we synchronise
      with the tasklet to ensure that it can't still be using the VCC before
      we continue and allow the VCC to be destroyed.
      
      Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
      Tested-by: default avatarNathan Williams <nathan@traverse.com.au>
      Cc: stable@kernel.org
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1f6ea6e5
  30. Aug 06, 2010
  31. Jul 24, 2010
  32. Jul 23, 2010
  33. Jul 15, 2010
Loading