- Sep 03, 2008
-
-
Ben Hutchings authored
Exclude assumed size of RX control frames from rx_bad_bytes. Exclude assumed size of TX control frames from tx_good_bytes for consistency with rx_good_bytes. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
We believed that some valid SNAP frames were being marked as invalid. In fact this is not the case and no workaround is needed. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Currently the board initialisation includes 2 delays of 1 second each. Usually it is unnecessary to wait that long, so check before doing so. Correct some of the comments and log messages while we're here. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
efx_test_loopback() used "|" to combine the results of the RX and TX phases. If both phases fail with different error codes, this results in a bogus error code. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Checksum generation is an attribute of our hardware TX queues, not TX descriptors. We previously used a single queue and turned checksum generation on or off as requested through ethtool. However, this can result in regenerating checksums in raw packets that should not be modified. We now create 2 hardware TX queues with checksum generation on or off. They are presented to the net core as one queue since it does not know how to select between them. The self-test verifies that a bad checksum is unaltered on the queue with checksum generation off. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Steve Hodgson authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
This means the compiler doesn't need to use real division instructions. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Use of the net_device::priv field is deprecated. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
- Jul 26, 2008
-
-
FUJITA Tomonori authored
Add per-device dma_mapping_ops support for CONFIG_X86_64 as POWER architecture does: This enables us to cleanly fix the Calgary IOMMU issue that some devices are not behind the IOMMU (http://lkml.org/lkml/2008/5/8/423 ). I think that per-device dma_mapping_ops support would be also helpful for KVM people to support PCI passthrough but Andi thinks that this makes it difficult to support the PCI passthrough (see the above thread). So I CC'ed this to KVM camp. Comments are appreciated. A pointer to dma_mapping_ops to struct dev_archdata is added. If the pointer is non NULL, DMA operations in asm/dma-mapping.h use it. If it's NULL, the system-wide dma_ops pointer is used as before. If it's useful for KVM people, I plan to implement a mechanism to register a hook called when a new pci (or dma capable) device is created (it works with hot plugging). It enables IOMMUs to set up an appropriate dma_mapping_ops per device. The major obstacle is that dma_mapping_error doesn't take a pointer to the device unlike other DMA operations. So x86 can't have dma_mapping_ops per device. Note all the POWER IOMMUs use the same dma_mapping_error function so this is not a problem for POWER but x86 IOMMUs use different dma_mapping_error functions. The first patch adds the device argument to dma_mapping_error. The patch is trivial but large since it touches lots of drivers and dma-mapping.h in all the architecture. This patch: dma_mapping_error() doesn't take a pointer to the device unlike other DMA operations. So we can't have dma_mapping_ops per device. Note that POWER already has dma_mapping_ops per device but all the POWER IOMMUs use the same dma_mapping_error function. x86 IOMMUs use device argument. [akpm@linux-foundation.org: fix sge] [akpm@linux-foundation.org: fix svc_rdma] [akpm@linux-foundation.org: build fix] [akpm@linux-foundation.org: fix bnx2x] [akpm@linux-foundation.org: fix s2io] [akpm@linux-foundation.org: fix pasemi_mac] [akpm@linux-foundation.org: fix sdhci] [akpm@linux-foundation.org: build fix] [akpm@linux-foundation.org: fix sparc] [akpm@linux-foundation.org: fix ibmvscsi] Signed-off-by:
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Cc: Muli Ben-Yehuda <muli@il.ibm.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@elte.hu> Cc: Avi Kivity <avi@qumranet.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
- Jul 22, 2008
-
-
Ben Hutchings authored
Using multiple cores in the same package to handle received traffic does not appear to provide a performance benefit. Therefore use CPU topology information to count CPU packages and use that as the default number of RX queues and interrupts. We rely on interrupt balancing to spread the interrupts across packages. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
This avoids deadlock in case a reset is triggered during self-test. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
As recommended by Jean Delvare: - Increase timeout to 50 ms - Leave adapter class clear so that unwanted drivers do not probe our bus - Use strlcpy() for name initialisation Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
- Jul 15, 2008
-
-
David S. Miller authored
Now that we have a specific lock to protect the network device unicast and multicast lists, remove extraneous grabs of the TX lock in cases where the code only needs address list protection. Signed-off-by:
David S. Miller <davem@davemloft.net>
-
David S. Miller authored
Add netif_addr_{lock,unlock}{,_bh}() helpers. Use them to protect operations that operate on or read the network device unicast and multicast address lists. Also use them in cases where the code simply wants to block calls into the driver's ->set_rx_mode() and ->set_multicast_list() methods. Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- Jun 10, 2008
-
-
Steve Hodgson authored
RX queue flush can fail if traffic continues to arrive. Recover by performing an invisible reset. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
- May 30, 2008
-
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Remove our own implementation of I2C bit-banging. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
This is normal when the external link is down so don't report it as an error. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
- May 22, 2008
-
-
Ben Hutchings authored
This driver has diverged from the out-of-tree driver to which the version number originally applied. It should be identified primarily by kernel version. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Remove redundant casts and variable. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Also change type of efx_nic_type::max_dma_mask to u64, matching pci_dma_supported() parameter type. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
These comments have been revised in response to questions raised by Andrew Morton in <20080501120858.207b6dd6.akpm@linux-foundation.org>. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
This should make the driver work on 32-bit systems with 64-bit PCI support. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Merged it into its only caller, efx_init_channels(). Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
- May 12, 2008
-
-
Ben Hutchings authored
Add a set of self-tests accessible thorugh ethtool. Add hardware loopback and TX disable control code to support them. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
An RX_RESET event can be reported either as a global or as a driver event. We were counting only global events. Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <bhutchings@solarflare.com> Signed-off-by:
Jeff Garzik <jgarzik@redhat.com>
-