Skip to content
Snippets Groups Projects
  1. Apr 29, 2011
  2. Apr 06, 2011
  3. Mar 28, 2011
    • Stanislaw Gruszka's avatar
      net: fix ethtool->set_flags not intended -EINVAL return value · 673e63c6
      Stanislaw Gruszka authored
      
      After commit d5dbda23 "ethtool: Add
      support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
      and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
      acceleration via ethtool set_flags, always return -EINVAL from that
      function. Fix by returning -EINVAL only if requested features do not
      match current settings and can not be changed by driver.
      
      Change any driver that define ethtool->set_flags to use
      ethtool_invalid_flags() to avoid similar problems in the future
      (also on drivers that do not have the problem).
      
      Tested with modified (to reproduce this bug) myri10ge driver.
      
      Cc: stable@kernel.org # 2.6.37+
      Signed-off-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      673e63c6
  4. Mar 15, 2011
  5. Jan 03, 2011
  6. Jun 30, 2010
  7. Jun 29, 2010
  8. May 13, 2010
  9. Mar 29, 2010
  10. Jan 15, 2010
  11. Jan 03, 2010
  12. Dec 03, 2009
  13. Oct 28, 2009
  14. Oct 13, 2009
  15. Sep 11, 2009
  16. Sep 07, 2009
  17. Sep 02, 2009
  18. Aug 23, 2009
  19. Jul 27, 2009
  20. Apr 28, 2009
  21. Apr 08, 2009
  22. Mar 14, 2009
  23. Mar 10, 2009
  24. Feb 27, 2009
  25. Feb 24, 2009
  26. Jan 26, 2009
  27. Jan 14, 2009
  28. Nov 21, 2008
  29. Sep 03, 2008
  30. Aug 23, 2008
  31. Aug 07, 2008
Loading