Skip to content
Snippets Groups Projects
  1. Jun 25, 2009
    • Ingo Molnar's avatar
      i2c: fix build bug in i2c-designware.c · 47749b14
      Ingo Molnar authored
      
      This build error triggers on x86:
      
       drivers/built-in.o: In function `i2c_dw_init':
       i2c-designware.c:(.text+0x4e37ca): undefined reference to `clk_get_rate'
       drivers/built-in.o: In function `dw_i2c_probe':
       i2c-designware.c:(.devinit.text+0x51f5e): undefined reference to `clk_get'
       i2c-designware.c:(.devinit.text+0x51f76): undefined reference to `clk_enable'
       i2c-designware.c:(.devinit.text+0x520ff): undefined reference to `clk_disable'
       i2c-designware.c:(.devinit.text+0x52108): undefined reference to `clk_put'
      
      Because this new driver uses the clk_*() facilities which is an
      ARM-only thing currently.
      
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      Acked-by: default avatarBaruch Siach <baruch@tkos.co.il>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      47749b14
  2. Jun 23, 2009
  3. Jun 21, 2009
    • Michael Trimarchi's avatar
      i2c: Fix stuck transaction on cpm-i2c driver · dc1972d0
      Michael Trimarchi authored
      
      When a process tries to read/write a disconnected i2c device, it receives a signal (e.g. ctrl-c) and the kernel gets stuck.
      
      BUG: soft lockup - CPU#0 stuck for 61s! [I2CEEpromTest:392]
      NIP: c01628f8 LR: c01628f0 CTR: c00177cc
      REGS: c39abd70 TRAP: 0901   Not tainted  (2.6.25.7-alcore)
      MSR: 00009032 <EE,ME,IR,DR>  CR: 42042048  XER: 20000000
      TASK = c3889bd0[392] 'I2CEEpromTest' THREAD: c39aa000
      GPR00: 00009000 c39abe20 c3889bd0 c39075c8 c39abe28 00000001 00000000 00000001
      GPR08: c3889bd0 c39075c8 00009032 c39abe34 00002437
      NIP [c01628f8] cpm_i2c_xfer+0x5fc/0x6d0
      LR [c01628f0] cpm_i2c_xfer+0x5f4/0x6d0
      Call Trace:
      [c39abe20] [c0162924] cpm_i2c_xfer+0x628/0x6d0 (unreliable)
      [c39abe90] [c015f6a0] i2c_transfer+0x88/0xb4
      [c39abeb0] [c0160164] i2c_master_recv+0x48/0x6c
      [c39abed0] [c01618dc] i2cdev_read+0x50/0xe4
      [c39abef0] [c0068b24] vfs_read+0xc4/0x108
      [c39abf10] [c0068f4c] sys_read+0x4c/0x90
      [c39abf40] [c000d348] ret_from_syscall+0x0/0x38
      Instruction dump:
      3bc00064 92610010 3bf201c8 92810014 3b61
      
      This happen because though the wait_event_interruptible_timeout takes the
      signals into account, the driver does not handle them.
      We propose to change the wait_event_interruptible_timeout with
      wait_event_timeout, leaving the signals to be handled in other points
      on the upper layers.
      
      Signed-off-by: default avatarBruno Morelli <bruno@evidence.eu.com>
      Signed-off-by: default avatarMichael Trimarchi <michael@evidence.eu.com>
      Acked-by: default avatarJochen Friedrich <jochen@scram.de>
      [ben-linux@fluff.org: fix title for patch]
      Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
      dc1972d0
    • Tony Lindgren's avatar
      i2c-omap: Fix build breaking typo cpu_is_omap_2430 · ff0f2426
      Tony Lindgren authored
      
      Hi Ben,
      
      Can you please queue this fix?
      
      Thanks,
      
      Tony
      
      >From ffe2b2cdf6283770b70a197e3748c6b40a1006be Mon Sep 17 00:00:00 2001
      From: Tony Lindgren <tony@atomide.com>
      Date: Wed, 17 Jun 2009 13:14:23 +0300
      Subject: [PATCH] i2c-omap: Fix build breaking typo in cpu_is_omap_2430
      
      Commit 84bf2c86 introduced a typo, it should be cpu_is_omap2430
      instead. The typo was probably caused by a mismerge.
      
      Without this patch all omaps fail to build with:
      error: implicit declaration of function 'cpu_is_omap_2430'
      
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
      ff0f2426
  4. Jun 19, 2009
  5. Jun 17, 2009
  6. Jun 16, 2009
  7. Jun 15, 2009
  8. Jun 13, 2009
  9. Jun 04, 2009
  10. May 13, 2009
  11. May 11, 2009
Loading