Skip to content
Snippets Groups Projects
  1. May 10, 2010
  2. Apr 27, 2010
  3. Apr 21, 2010
  4. Apr 13, 2010
  5. Apr 03, 2010
  6. Apr 01, 2010
  7. Mar 30, 2010
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  8. Mar 27, 2010
  9. Feb 28, 2010
  10. Feb 19, 2010
  11. Feb 12, 2010
  12. Jan 23, 2010
  13. Jan 17, 2010
  14. Jan 07, 2010
  15. Jan 06, 2010
  16. Jan 03, 2010
  17. Dec 13, 2009
  18. Dec 07, 2009
  19. Dec 03, 2009
  20. Nov 28, 2009
    • Dominik Brodowski's avatar
      pcmcia: rework the irq_req_t typedef · 5fa9167a
      Dominik Brodowski authored
      
      Most of the irq_req_t typedef'd struct can be re-worked quite
      easily:
      
      (1) IRQInfo2 was unused in any case, so drop it.
      
      (2) IRQInfo1 was used write-only, so drop it.
      
      (3) Instance (private data to be passed to the IRQ handler):
      	Most PCMCIA drivers using pcmcia_request_irq() to actually
      	register an IRQ handler set the "dev_id" to the same pointer
      	as the "priv" pointer in struct pcmcia_device. Modify the two
      	exceptions (ipwireless, ibmtr_cs) to also work this waym and
      	set the IRQ handler's "dev_id" to p_dev->priv unconditionally.
      
      (4) Handler is to be of type irq_handler_t.
      
      (5) Handler != NULL already tells whether an IRQ handler is present.
      	Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
      	irq_req_t.Attributes.
      
      CC: netdev@vger.kernel.org
      CC: linux-bluetooth@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: Jaroslav Kysela <perex@perex.cz>
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: Karsten Keil <isdn@linux-pingi.de>
      for the Bluetooth parts: Acked-by: Marcel Holtmann <marcel@holtmann.org>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      5fa9167a
    • Dominik Brodowski's avatar
      pcmcia: remove deprecated handle_to_dev() macro · dd2e5a15
      Dominik Brodowski authored
      
      Update remaining users and remove deprecated handle_to_dev() macro
      
      CC: Harald Welte <laforge@gnumonks.org>
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-serial@vger.kernel.org
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      dd2e5a15
    • Dominik Brodowski's avatar
      pcmcia: pcmcia_request_window() doesn't need a pointer to a pointer · 6838b03f
      Dominik Brodowski authored
      
      pcmcia_request_window() only needs a pointer to struct pcmcia_device, not
      a pointer to a pointer.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Acked-by: Karsten Keil <keil@b1-systems.de> (for ISDN)
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      6838b03f
    • Magnus Damm's avatar
      pcmcia: Change window_handle_t logic to unsigned long · 0bdf9b3d
      Magnus Damm authored
      
      Logic changes based on top of the other patches:
      
      This set of patches changed window_handle_t from being a pointer to an
      unsigned long. The unsigned long is now a simple index into socket->win[].
      Going from a pointer to unsigned long should leave the user space interface
      unchanged unless I'm mistaken.
      
      This change results in code that is less error prone and a user space
      interface which is much cleaner and safer. A nice side effect is that we
      are also are able to remove all members except one from window_t.
      
      [ linux@dominikbrodowski.net:
      	Update to 2.6.31. Also, a plain "index" to socket->win[] does not
      	work, as several codepaths rely on "window_handle_t" being
      	non-zero if used. Therefore, set the window_handle_t to the
      	socket->win[] index + 1. ]
      
      CC: netdev@vger.kernel.org
      Signed-off-by: default avatarMagnus Damm <damm@opensource.se>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      0bdf9b3d
    • Magnus Damm's avatar
      pcmcia: Pass struct pcmcia_device to pcmcia_map_mem_page() · 868575d1
      Magnus Damm authored
      
      No logic changes, just pass struct pcmcia_device to pcmcia_map_mem_page()
      
      [linux@dominikbrodowski.net: update to 2.6.31]
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Acked-by: Karsten Keil <keil@b1-systems.de> (for ISDN)
      Signed-off-by: default avatarMagnus Damm <damm@opensource.se>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      868575d1
    • Magnus Damm's avatar
      pcmcia: Pass struct pcmcia_device to pcmcia_release_window() · f5560da5
      Magnus Damm authored
      
      No logic changes, just pass struct pcmcia_device to pcmcia_release_window().
      
      [linux@dominikbrodowski.net: update to 2.6.31]
      CC: netdev@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Signed-off-by: default avatarMagnus Damm <damm@opensource.se>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      f5560da5
  21. Nov 18, 2009
  22. Nov 10, 2009
  23. Nov 09, 2009
    • Dominik Brodowski's avatar
      pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (net) · dd0fab5b
      Dominik Brodowski authored
      
      Convert PCMCIA drivers to use the dynamic debug infrastructure, instead of
      requiring manual settings of PCMCIA_DEBUG. Only some rare debug checks are
      now hidden behind "#ifdef DEBUG" or "#if 0".
      
      Also, remove all usages of the CS_CHECK macro and replace them with proper
      Linux style calling and return value checking. The extra error reporting may
      be dropped, as the PCMCIA core already complains about any (non-driver-author)
      errors.
      
      CC: netdev@vger.kernel.org
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      dd0fab5b
  24. Nov 08, 2009
  25. Oct 29, 2009
  26. Oct 13, 2009
  27. Oct 05, 2009
  28. Sep 22, 2009
  29. Sep 15, 2009
  30. Sep 03, 2009
  31. Sep 01, 2009
Loading