Skip to content
Snippets Groups Projects
  1. Sep 29, 2010
    • Dominik Brodowski's avatar
      pcmcia: convert pcmcia_request_configuration to pcmcia_enable_device · 1ac71e5a
      Dominik Brodowski authored
      
      pcmcia_enable_device() now replaces pcmcia_request_configuration().
      Instead of config_req_t, all necessary flags are either passed as
      a parameter to pcmcia_enable_device(), or (in rare circumstances)
      set in struct pcmcia_device -> flags.
      
      With the last remaining user of include/pcmcia/cs.h gone, remove
      all references.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Acked-by: Gustavo F. Padovan <padovan@profusion.mobi> (for drivers/bluetooth)
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      1ac71e5a
    • Dominik Brodowski's avatar
      pcmcia: move config_{base,index,regs} to struct pcmcia_device · 7feabb64
      Dominik Brodowski authored
      
      Several drivers prefer to explicitly set config_{base,index,regs},
      formerly known as ConfigBase, ConfigIndex and Present. Instead of
      passing these values inside config_req_t, store it in struct
      pcmcia_device.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Acked-by: Gustavo F. Padovan <padovan@profusion.mobi> (for drivers/bluetooth)
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      7feabb64
    • Dominik Brodowski's avatar
      pcmcia: simplify IntType · 37979e15
      Dominik Brodowski authored
      
      IntType was only set to INT_MEMORY (driver pcmciamtd) or INT_MEMORY_AND_IO
      (all other drivers). As this flags seems to relate to ioport access, make
      it conditional to the driver having requested IO port access. There are two
      drivers which do not request IO ports, but did set INT_MEMORY_AND_IO:
      ray_cs and b43. For those, we consistently only set INT_MEMORY in future.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Acked-by: Gustavo F. Padovan <padovan@profusion.mobi> (for drivers/bluetooth)
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      37979e15
    • Dominik Brodowski's avatar
      pcmcia: simplify Status, ExtStatus register access · fc301101
      Dominik Brodowski authored
      
      The Status (CISREG_CCSR) and ExtStatus (CISREG_ESR) registers were
      only accessed to enable audio output for some drivers and IRQ for
      serial_cs.c. The former also required setting config_req_t.Attributes
      to CONF_ENABLE_SPKR; the latter can be simplified to setting this
      field to CONF_ENABLE_ESR.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-serial@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      fc301101
    • Dominik Brodowski's avatar
      pcmcia: split up modify_configuration() into two fixup functions · fb49fa53
      Dominik Brodowski authored
      
      pcmcia_modify_configuration() was only used by two drivers to fix up
      one issue each: setting the Vpp to a different value, and reducing
      the IO width to 8 bit. Introduce two explicitly named functions
      handling these things, and remove one further typedef.
      
      CC: netdev@vger.kernel.org
      CC: linux-mtd@lists.infradead.org
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      fb49fa53
    • Dominik Brodowski's avatar
      pcmcia: do not use win_req_t when calling pcmcia_request_window() · cdb13808
      Dominik Brodowski authored
      
      Instead of win_req_t, drivers are now requested to fill out
      struct pcmcia_device *p_dev->resource[2,3,4,5] for up to four iomem
      ranges. After a call to pcmcia_request_window(), the windows found there
      are reserved and may be used until pcmcia_release_window() is called.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-mtd@lists.infradead.org
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: linux-scsi@vger.kernel.org
      Tested-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      cdb13808
  2. Sep 15, 2010
  3. Aug 28, 2010
  4. Aug 13, 2010
  5. Aug 03, 2010
    • Dominik Brodowski's avatar
      pcmcia: use struct resource for PCMCIA devices, part 2 · 0ca724d3
      Dominik Brodowski authored
      
      Use struct resource * also for iomem resources.
      
      CC: linux-mtd@lists.infradead.org
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: Jiri Kosina <jkosina@suse.cz>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      0ca724d3
    • Dominik Brodowski's avatar
      pcmcia: remove memreq_t · b5cb259e
      Dominik Brodowski authored
      
      Page already had to be set to 0; Offset can easily be passed as
      parameter to pcmcia_map_mem_page.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: linux-bluetooth@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Michael Buesch <mb@bu3sch.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      b5cb259e
    • Dominik Brodowski's avatar
      pcmcia: do not use io_req_t when calling pcmcia_request_io() · 90abdc3b
      Dominik Brodowski authored
      
      Instead of io_req_t, drivers are now requested to fill out
      struct pcmcia_device *p_dev->resource[0,1] for up to two ioport
      ranges. After a call to pcmcia_request_io(), the ports found there
      are reserved, after calling pcmcia_request_configuration(), they may
      be used.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      CC: Michael Buesch <mb@bu3sch.de>
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      90abdc3b
    • Dominik Brodowski's avatar
      pcmcia: do not use io_req_t after call to pcmcia_request_io() · 9a017a91
      Dominik Brodowski authored
      
      After pcmcia_request_io(), do not make use of the values stored in
      io_req_t, but instead use those found in struct pcmcia_device->resource[].
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      9a017a91
    • Dominik Brodowski's avatar
      pcmcia: use pcmica_{read,write}_config_byte · 1d5cc192
      Dominik Brodowski authored
      
      Use pcmcia_read_config_byte and pcmcia_write_config_byte instead
      of pcmcia_access_configuration_register.
      
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-serial@vger.kernel.org
      CC: Michael Buesch <mb@bu3sch.de>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      1d5cc192
  6. Jul 30, 2010
    • Dominik Brodowski's avatar
      pcmcia: remove cs_types.h · ac8b4228
      Dominik Brodowski authored
      
      Remove cs_types.h which is no longer needed: Most definitions aren't
      used at all, a few can be made away with, and two remaining definitions
      (typedefs, unfortunatley) may be moved to more specific places.
      
      CC: linux-ide@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      CC: laforge@gnumonks.org
      CC: linux-mtd@lists.infradead.org
      CC: alsa-devel@alsa-project.org
      CC: linux-serial@vger.kernel.org
      Acked-by: Marcel Holtmann <marcel@holtmann.org> (for drivers/bluetooth/)
      Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
      ac8b4228
  7. Jul 12, 2010
  8. Jun 25, 2010
  9. Jun 16, 2010
  10. Jun 15, 2010
  11. Jun 07, 2010
  12. May 14, 2010
    • Joe Perches's avatar
      drivers/net: Remove unnecessary returns from void function()s · a4b77097
      Joe Perches authored
      
      This patch removes from drivers/net/ all the unnecessary
      return; statements that precede the last closing brace of
      void functions.
      
      It does not remove the returns that are immediately
      preceded by a label as gcc doesn't like that.
      
      It also does not remove null void functions with return.
      
      Done via:
      $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
        xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'
      
      with some cleanups by hand.
      
      Compile tested x86 allmodconfig only.
      
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a4b77097
  13. May 10, 2010
  14. Apr 27, 2010
  15. Apr 21, 2010
  16. Apr 13, 2010
  17. Apr 03, 2010
  18. Apr 01, 2010
  19. Mar 30, 2010
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  20. Mar 27, 2010
  21. Feb 28, 2010
  22. Feb 19, 2010
  23. Feb 12, 2010
  24. Jan 23, 2010
  25. Jan 17, 2010
  26. Jan 07, 2010
  27. Jan 06, 2010
Loading