fs: icache RCU free inodes
RCU free the struct inode. This will allow:
- Subsequent store-free path walking patch. The inode must be consulted for
permissions when walking, so an RCU inode reference is a must.
- sb_inode_list_lock to be moved inside i_lock because sb list walkers who want
to take i_lock no longer need to take sb_inode_list_lock to walk the list in
the first place. This will simplify and optimize locking.
- Could remove some nested trylock loops in dcache code
- Could potentially simplify things a bit in VM land. Do not need to take the
page lock to follow page->mapping.
The downsides of this is the performance cost of using RCU. In a simple
creat/unlink microbenchmark, performance drops by about 10% due to inability to
reuse cache-hot slab objects. As iterations increase and RCU freeing starts
kicking over, this increases to about 20%.
In cases where inode lifetimes are longer (ie. many inodes may be allocated
during the average life span of a single inode), a lot of this cache reuse is
not applicable, so the regression caused by this patch is smaller.
The cache-hot regression could largely be avoided by using SLAB_DESTROY_BY_RCU,
however this adds some complexity to list walking and store-free path walking,
so I prefer to implement this at a later date, if it is shown to be a win in
real situations. I haven't found a regression in any non-micro benchmark so I
doubt it will be a problem.
Signed-off-by:
Nick Piggin <npiggin@kernel.dk>
Showing
- Documentation/filesystems/porting 14 additions, 0 deletionsDocumentation/filesystems/porting
- arch/powerpc/platforms/cell/spufs/inode.c 8 additions, 2 deletionsarch/powerpc/platforms/cell/spufs/inode.c
- drivers/staging/pohmelfs/inode.c 8 additions, 1 deletiondrivers/staging/pohmelfs/inode.c
- drivers/staging/smbfs/inode.c 8 additions, 1 deletiondrivers/staging/smbfs/inode.c
- fs/9p/vfs_inode.c 8 additions, 1 deletionfs/9p/vfs_inode.c
- fs/adfs/super.c 8 additions, 1 deletionfs/adfs/super.c
- fs/affs/super.c 8 additions, 1 deletionfs/affs/super.c
- fs/afs/super.c 9 additions, 1 deletionfs/afs/super.c
- fs/befs/linuxvfs.c 8 additions, 2 deletionsfs/befs/linuxvfs.c
- fs/bfs/inode.c 8 additions, 1 deletionfs/bfs/inode.c
- fs/block_dev.c 8 additions, 1 deletionfs/block_dev.c
- fs/btrfs/inode.c 8 additions, 1 deletionfs/btrfs/inode.c
- fs/ceph/inode.c 10 additions, 1 deletionfs/ceph/inode.c
- fs/cifs/cifsfs.c 8 additions, 1 deletionfs/cifs/cifsfs.c
- fs/coda/inode.c 8 additions, 1 deletionfs/coda/inode.c
- fs/ecryptfs/super.c 11 additions, 1 deletionfs/ecryptfs/super.c
- fs/efs/super.c 8 additions, 1 deletionfs/efs/super.c
- fs/exofs/super.c 8 additions, 1 deletionfs/exofs/super.c
- fs/ext2/super.c 8 additions, 1 deletionfs/ext2/super.c
- fs/ext3/super.c 8 additions, 1 deletionfs/ext3/super.c
Loading
Please register or sign in to comment