Skip to content
Snippets Groups Projects
Commit ebbb0ef2 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Al Viro
Browse files

9p: do no return 0 from ->check_acl without actually checking


If we do not want to use ACLs we at least need to perform normal Unix
permission checks.  From the comment I'm not quite sure that's what
is intended, but if 0p wants to do permission checks entirely on the
server it needs to do so in ->permission, not in ->check_acl.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent e77819e5
No related branches found
No related tags found
No related merge requests found
...@@ -108,7 +108,7 @@ int v9fs_check_acl(struct inode *inode, int mask) ...@@ -108,7 +108,7 @@ int v9fs_check_acl(struct inode *inode, int mask)
* On access = client and acl = on mode get the acl * On access = client and acl = on mode get the acl
* values from the server * values from the server
*/ */
return 0; return -EAGAIN;
} }
acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS); acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment