Skip to content
Snippets Groups Projects
Commit e847cc83 authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: drop sizeof expressions from some request size arguments


In case of fw_card_bm_work()'s lock request, the present sizeof
expression is going to be wrong if somebody changes the fw_card's DMA
scratch buffer's size in the future.

In case of quadlet write requests, sizeof(u32) is just silly; it's 4.

In case of SBP-2 ORB pointer write requests, 8 is arguably quicker to
understand as the correct and only possible value than
sizeof(some_datum).

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 65b2742a
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment