tree-wide: convert open calls to remove spaces to skip_spaces() lib function
Makes use of skip_spaces() defined in lib/string.c for removing leading spaces from strings all over the tree. It decreases lib.a code size by 47 bytes and reuses the function tree-wide: text data bss dec hex filename 64688 584 592 65864 10148 (TOTALS-BEFORE) 64641 584 592 65817 10119 (TOTALS-AFTER) Also, while at it, if we see (*str && isspace(*str)), we can be sure to remove the first condition (*str) as the second one (isspace(*str)) also evaluates to 0 whenever *str == 0, making it redundant. In other words, "a char equals zero is never a space". Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr ) below, and found occurrences of this pattern on 3 more files: drivers/leds/led-class.c drivers/leds/ledtrig-timer.c drivers/video/output.c @@ expression str; @@ ( // ignore skip_spaces cases while (*str && isspace(*str)) { \(str++;\|++str;\) } | - *str && isspace(*str) ) Signed-off-by:André Goddard Rosa <andre.goddard@gmail.com> Cc: Julia Lawall <julia@diku.dk> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Jeff Dike <jdike@addtoit.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Neil Brown <neilb@suse.de> Cc: Kyle McMartin <kyle@mcmartin.ca> Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Cc: David Howells <dhowells@redhat.com> Cc: <linux-ext4@vger.kernel.org> Cc: Samuel Ortiz <samuel@sortiz.org> Cc: Patrick McHardy <kaber@trash.net> Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- arch/s390/kernel/debug.c 2 additions, 1 deletionarch/s390/kernel/debug.c
- arch/um/drivers/mconsole_kern.c 7 additions, 9 deletionsarch/um/drivers/mconsole_kern.c
- arch/x86/kernel/cpu/mtrr/if.c 4 additions, 7 deletionsarch/x86/kernel/cpu/mtrr/if.c
- drivers/leds/led-class.c 1 addition, 1 deletiondrivers/leds/led-class.c
- drivers/leds/ledtrig-timer.c 2 additions, 2 deletionsdrivers/leds/ledtrig-timer.c
- drivers/md/dm-table.c 2 additions, 4 deletionsdrivers/md/dm-table.c
- drivers/md/md.c 2 additions, 2 deletionsdrivers/md/md.c
- drivers/parisc/pdc_stable.c 3 additions, 6 deletionsdrivers/parisc/pdc_stable.c
- drivers/platform/x86/thinkpad_acpi.c 2 additions, 5 deletionsdrivers/platform/x86/thinkpad_acpi.c
- drivers/pnp/interface.c 10 additions, 26 deletionsdrivers/pnp/interface.c
- drivers/s390/block/dasd_proc.c 3 additions, 2 deletionsdrivers/s390/block/dasd_proc.c
- drivers/video/backlight/lcd.c 2 additions, 2 deletionsdrivers/video/backlight/lcd.c
- drivers/video/display/display-sysfs.c 1 addition, 1 deletiondrivers/video/display/display-sysfs.c
- drivers/video/output.c 1 addition, 1 deletiondrivers/video/output.c
- fs/cachefiles/daemon.c 2 additions, 2 deletionsfs/cachefiles/daemon.c
- fs/ext4/super.c 2 additions, 5 deletionsfs/ext4/super.c
- kernel/params.c 3 additions, 5 deletionskernel/params.c
- lib/argv_split.c 3 additions, 10 deletionslib/argv_split.c
- lib/dynamic_debug.c 2 additions, 2 deletionslib/dynamic_debug.c
- lib/vsprintf.c 4 additions, 11 deletionslib/vsprintf.c
Loading
Please register or sign in to comment