netdev: bunch of drivers: avoid WARN at net/core/dev.c:1328
The drivers were touching net queue before it has been started, so without this patch, the drivers will potentially WARN at net/core/dev.c:1328. I don't have the hardware for the drivers below, so this patch is untested, and thus should be carefully peer reviewed. tc35815.c au1000_eth.c bfin_mac.c macb.c ^ The four drivers are using phylib, they're calling netif_start_queue() in open() callback. So trivially remove netif_tx_schedule_all(). Phylib will handle netif_carrier_*(). cpmac.c fec_mpc52xx.c fs_enet/fs_enet-main.c sh_eth.c ^ The same as above, but these were also needlessly calling netif_carrier_*() functions. So removed queue calls and also remove carrier calls, since phylib will handle it. fs_enet-main.c also didn't call netif_start_queue() at open(), this is fixed now. Signed-off-by:Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- drivers/net/au1000_eth.c 2 additions, 3 deletionsdrivers/net/au1000_eth.c
- drivers/net/bfin_mac.c 0 additions, 1 deletiondrivers/net/bfin_mac.c
- drivers/net/cpmac.c 0 additions, 2 deletionsdrivers/net/cpmac.c
- drivers/net/fec_mpc52xx.c 0 additions, 5 deletionsdrivers/net/fec_mpc52xx.c
- drivers/net/fs_enet/fs_enet-main.c 2 additions, 5 deletionsdrivers/net/fs_enet/fs_enet-main.c
- drivers/net/macb.c 1 addition, 3 deletionsdrivers/net/macb.c
- drivers/net/sh_eth.c 0 additions, 5 deletionsdrivers/net/sh_eth.c
- drivers/net/tc35815.c 0 additions, 1 deletiondrivers/net/tc35815.c
Loading
Please register or sign in to comment