Commit c75b590d authored by Rusty Russell's avatar Rusty Russell

module: fix redundant test.

[linux-4.5-rc4/kernel/module.c:1692]: (style) Redundant condition: attr.test.
'!attr.test || (attr.test && attr.test(mod))' is equivalent to '!attr.test ||

This code was added like this ten years ago, in c988d2b2
"modules: add version and srcversion to sysfs".
Reported-by: default avatarDavid Binderman <>
Cc: Matt Domsch <>
Signed-off-by: default avatarRusty Russell <>
parent bf262dce
......@@ -1693,8 +1693,7 @@ static int module_add_modinfo_attrs(struct module *mod)
temp_attr = mod->modinfo_attrs;
for (i = 0; (attr = modinfo_attrs[i]) && !error; i++) {
if (!attr->test ||
(attr->test && attr->test(mod))) {
if (!attr->test || attr->test(mod)) {
memcpy(temp_attr, attr, sizeof(*temp_attr));
error = sysfs_create_file(&mod->mkobj.kobj,
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment