[NET]: Inline net_device_stats
Network drivers which keep stats allocate their own stats structure then write a get_stats() function to return them. It would be nice if this were done by default. 1) Add a new "stats" field to "struct net_device". 2) Add a new feature field to say "this driver uses the internal one" 3) Have a default "get_stats" which returns NULL if that feature not set. 4) Change callers to check result of get_stats call for NULL, not if ->get_stats is set. This should not break backwards compatibility with older drivers, yet allow modern drivers to shed some boilerplate code. Lightly tested: works for a modified lguest network driver. Signed-off-by:Rusty Russell <rusty@rustcorp.com.au> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- arch/s390/appldata/appldata_net_sum.c 2 additions, 2 deletionsarch/s390/appldata/appldata_net_sum.c
- drivers/net/bonding/bond_main.c 2 additions, 3 deletionsdrivers/net/bonding/bond_main.c
- drivers/parisc/led.c 2 additions, 2 deletionsdrivers/parisc/led.c
- include/linux/netdevice.h 2 additions, 0 deletionsinclude/linux/netdevice.h
- net/core/dev.c 10 additions, 3 deletionsnet/core/dev.c
Loading
Please register or sign in to comment