Skip to content
Snippets Groups Projects
Commit bad97c37 authored by Jin Dongming's avatar Jin Dongming Committed by Len Brown
Browse files

ACPI, APEI, Fix acpi_pre_map() return value


After we ioremap() a new region, we call __acpi_try_ioremap() to
see whether another thread has already mapped the same region.
This check clobbers "vaddr",  so compute the return value of
acpi_pre_map() using the ioremap() result "map->vaddr" instead.

v2:
    Modified the unsuitable description of patch.

v3:
    Removed unlikely() check and made description simpler.

Signed-off-by: default avatarJin Dongming <jin.dongming@np.css.fujitsu.com>
Reviewed-by: default avatarAndi Kleen <ak@linux.intel.com>
Signed-off-by: default avatarHuang Ying <ying.huang@intel.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 3a78f965
No related branches found
Tags v2.6.34-rc7
No related merge requests found
...@@ -142,7 +142,7 @@ static void __iomem *acpi_pre_map(phys_addr_t paddr, ...@@ -142,7 +142,7 @@ static void __iomem *acpi_pre_map(phys_addr_t paddr,
list_add_tail_rcu(&map->list, &acpi_iomaps); list_add_tail_rcu(&map->list, &acpi_iomaps);
spin_unlock_irqrestore(&acpi_iomaps_lock, flags); spin_unlock_irqrestore(&acpi_iomaps_lock, flags);
return vaddr + (paddr - pg_off); return map->vaddr + (paddr - map->paddr);
err_unmap: err_unmap:
iounmap(vaddr); iounmap(vaddr);
return NULL; return NULL;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment