Commit ada83daa authored by Andre Detsch's avatar Andre Detsch Committed by Paul Mackerras
Browse files

[POWERPC] spufs: Don't call spu_run_init from spu_reacquire_runnable

This fixes a major bug which was happening when a SPU thread advances
its execution right after being restored to a SPU.  A potentially
outdated NPC value was being (re)written to the SPU.

So, spu_run_init, in this case, was either not doing anything relevant,
or breaking the execution of the SPU thread.

This fixes a common problem of losing a mailbox write when it was done
to a saved context.
Signed-off-by: default avatarAndre Detsch <>
Signed-off-by: default avatarJeremy Kerr <>
Signed-off-by: default avatarPaul Mackerras <>
parent 62ee68e3
......@@ -193,11 +193,7 @@ static int spu_reacquire_runnable(struct spu_context *ctx, u32 *npc,
if (ret)
return ret;
ret = spu_run_init(ctx, npc);
if (ret) {
return ret;
spuctx_switch_state(ctx, SPU_UTIL_USER);
return 0;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment