x86: i386-show-unhandled-signals-v3
This patch makes the i386 behave the same way that x86_64 does when a segfault happens. A line gets printed to the kernel log so that tools that need to check for failures can behave more uniformly between debug.show_unhandled_signals sysctl variable to 0 (or by doing echo 0 > /proc/sys/debug/exception-trace) Also, all of the lines being printed are now using printk_ratelimit() to deny the ability of DoS from a local user with a program like the following: main() { while (1) if (!fork()) *(int *)0 = 0; } This new revision also includes the fix that Andrew did which got rid of new sysctl that was added to the system in earlier versions of this. Also, 'show-unhandled-signals' sysctl has been renamed back to the old 'exception-trace' to avoid breakage of people's scripts. AK: Enabling by default for i386 will be likely controversal, but let's see what happens AK: Really folks, before complaining just fix your segfaults AK: I bet this will find a lot of silent issues Signed-off-by:Masoud Sharbiani <masouds@google.com> Signed-off-by:
Andi Kleen <ak@suse.de> [ Personally, I've found the complaints useful on x86-64, so I'm all for this. That said, I wonder if we could do it more prettily.. -Linus ] Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- arch/i386/kernel/signal.c 7 additions, 0 deletionsarch/i386/kernel/signal.c
- arch/i386/kernel/traps.c 7 additions, 0 deletionsarch/i386/kernel/traps.c
- arch/i386/mm/fault.c 10 additions, 0 deletionsarch/i386/mm/fault.c
- arch/x86_64/kernel/signal.c 1 addition, 1 deletionarch/x86_64/kernel/signal.c
- arch/x86_64/kernel/traps.c 4 additions, 2 deletionsarch/x86_64/kernel/traps.c
- arch/x86_64/mm/fault.c 3 additions, 12 deletionsarch/x86_64/mm/fault.c
- arch/x86_64/mm/init.c 0 additions, 33 deletionsarch/x86_64/mm/init.c
- include/asm-x86_64/proto.h 0 additions, 2 deletionsinclude/asm-x86_64/proto.h
- include/linux/signal.h 3 additions, 0 deletionsinclude/linux/signal.h
- kernel/signal.c 10 additions, 0 deletionskernel/signal.c
- kernel/sysctl.c 10 additions, 0 deletionskernel/sysctl.c
Loading