[PATCH] vfs: MS_VERBOSE should be MS_SILENT
The meaning of MS_VERBOSE is backwards; if the bit is set, it really means, "don't be verbose". This is confusing and counter-intuitive. In addition, there is also no way to set the MS_VERBOSE flag in the mount(8) program in util-linux, but interesting, it does define options which would do the right thing if MS_SILENT were defined, which unfortunately we do not: #ifdef MS_SILENT { "quiet", 0, 0, MS_SILENT }, /* be quiet */ { "loud", 0, 1, MS_SILENT }, /* print out messages. */ #endif So the obvious fix is to deprecate the use of MS_VERBOSE and replace it with MS_SILENT. Signed-off-by:"Theodore Ts'o" <tytso@mit.edu> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
Showing
- fs/afs/super.c 1 addition, 1 deletionfs/afs/super.c
- fs/cifs/cifsfs.c 1 addition, 1 deletionfs/cifs/cifsfs.c
- fs/jffs2/super.c 2 additions, 2 deletionsfs/jffs2/super.c
- fs/nfs/inode.c 2 additions, 2 deletionsfs/nfs/inode.c
- fs/super.c 3 additions, 3 deletionsfs/super.c
- include/linux/fs.h 3 additions, 1 deletioninclude/linux/fs.h
- init/do_mounts.c 1 addition, 1 deletioninit/do_mounts.c
Loading
Please register or sign in to comment