proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy as correctly noted at bug #12454. Someone can lookup entry with NULL ->owner, thus not pinning enything, and release it later resulting in module refcount underflow. We can keep ->owner and supply it at registration time like ->proc_fops and ->data. But this leaves ->owner as easy-manipulative field (just one C assignment) and somebody will forget to unpin previous/pin current module when switching ->owner. ->proc_fops is declared as "const" which should give some thoughts. ->read_proc/->write_proc were just fixed to not require ->owner for protection. rmmod'ed directories will be empty and return "." and ".." -- no harm. And directories with tricky enough readdir and lookup shouldn't be modular. We definitely don't want such modular code. Removing ->owner will also make PDE smaller. So, let's nuke it. Kudos to Jeff Layton for reminding about this, let's say, oversight. http://bugzilla.kernel.org/show_bug.cgi?id=12454 Signed-off-by:Alexey Dobriyan <adobriyan@gmail.com>
Showing
- Documentation/DocBook/procfs_example.c 0 additions, 9 deletionsDocumentation/DocBook/procfs_example.c
- arch/alpha/kernel/srm_env.c 0 additions, 5 deletionsarch/alpha/kernel/srm_env.c
- arch/blackfin/mm/sram-alloc.c 0 additions, 1 deletionarch/blackfin/mm/sram-alloc.c
- arch/ia64/kernel/palinfo.c 0 additions, 2 deletionsarch/ia64/kernel/palinfo.c
- arch/ia64/sn/kernel/sn2/prominfo_proc.c 2 additions, 7 deletionsarch/ia64/sn/kernel/sn2/prominfo_proc.c
- arch/powerpc/kernel/rtas_flash.c 0 additions, 1 deletionarch/powerpc/kernel/rtas_flash.c
- arch/sparc/kernel/led.c 0 additions, 1 deletionarch/sparc/kernel/led.c
- arch/x86/kernel/cpu/mtrr/if.c 1 addition, 9 deletionsarch/x86/kernel/cpu/mtrr/if.c
- drivers/acpi/ac.c 0 additions, 1 deletiondrivers/acpi/ac.c
- drivers/acpi/battery.c 0 additions, 1 deletiondrivers/acpi/battery.c
- drivers/acpi/button.c 0 additions, 3 deletionsdrivers/acpi/button.c
- drivers/acpi/fan.c 0 additions, 2 deletionsdrivers/acpi/fan.c
- drivers/acpi/processor_core.c 0 additions, 2 deletionsdrivers/acpi/processor_core.c
- drivers/acpi/sbs.c 0 additions, 1 deletiondrivers/acpi/sbs.c
- drivers/acpi/thermal.c 0 additions, 2 deletionsdrivers/acpi/thermal.c
- drivers/acpi/video.c 0 additions, 5 deletionsdrivers/acpi/video.c
- drivers/block/ps3vram.c 0 additions, 2 deletionsdrivers/block/ps3vram.c
- drivers/char/ipmi/ipmi_msghandler.c 4 additions, 8 deletionsdrivers/char/ipmi/ipmi_msghandler.c
- drivers/char/ipmi/ipmi_si_intf.c 3 additions, 3 deletionsdrivers/char/ipmi/ipmi_si_intf.c
- drivers/input/input.c 0 additions, 2 deletionsdrivers/input/input.c
Loading
Please register or sign in to comment