[PATCH] remove TTY_DONT_FLIP
Remove TTY_DONT_FLIP tty flag. This flag was introduced in 2.1.X kernels to prevent the N_TTY line discipline functions read_chan() and n_tty_receive_buf() from running at the same time. 2.2.15 introduced tty->read_lock to protect access to the N_TTY read buffer, which is the only state requiring protection between these two functions. The current TTY_DONT_FLIP implementation is broken for SMP, and is not universally honored by drivers that send data directly to the line discipline receive_buf function. Because TTY_DONT_FLIP is not necessary, is broken in implementation, and is not universally honored, it is removed. Signed-off-by:Paul Fulghum <paulkf@microgate.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Theodore Ts'o <tytso@mit.edu> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
Showing
- drivers/char/mxser.c 0 additions, 1 deletiondrivers/char/mxser.c
- drivers/char/n_tty.c 1 addition, 5 deletionsdrivers/char/n_tty.c
- drivers/char/pty.c 1 addition, 1 deletiondrivers/char/pty.c
- drivers/char/tty_io.c 2 additions, 13 deletionsdrivers/char/tty_io.c
- drivers/serial/crisv10.c 0 additions, 6 deletionsdrivers/serial/crisv10.c
- drivers/serial/jsm/jsm_tty.c 0 additions, 7 deletionsdrivers/serial/jsm/jsm_tty.c
- drivers/usb/serial/ir-usb.c 1 addition, 2 deletionsdrivers/usb/serial/ir-usb.c
- include/linux/tty.h 0 additions, 1 deletioninclude/linux/tty.h
- net/bluetooth/rfcomm/tty.c 2 additions, 6 deletionsnet/bluetooth/rfcomm/tty.c
Loading
Please register or sign in to comment