[NET_SCHED]: act_api: qdisc internal reclassify support
The behaviour of NET_CLS_POLICE for TC_POLICE_RECLASSIFY was to return it to the qdisc, which could handle it internally or ignore it. With NET_CLS_ACT however, tc_classify starts over at the first classifier and never returns it to the qdisc. This makes it impossible to support qdisc-internal reclassification, which in turn makes it impossible to remove the old NET_CLS_POLICE code without breaking compatibility since we have two qdiscs (CBQ and ATM) that support this. This patch adds a tc_classify_compat function that handles reclassification the old way and changes CBQ and ATM to use it. This again is of course not fully backwards compatible with the previous NET_CLS_ACT behaviour. Unfortunately there is no way to fully maintain compatibility *and* support qdisc internal reclassification with NET_CLS_ACT, but this seems like the better choice over keeping the two incompatible options around forever. Signed-off-by:Patrick McHardy <kaber@trash.net> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- include/net/pkt_sched.h 3 additions, 1 deletioninclude/net/pkt_sched.h
- include/net/sch_generic.h 1 addition, 1 deletioninclude/net/sch_generic.h
- net/sched/sch_api.c 38 additions, 29 deletionsnet/sched/sch_api.c
- net/sched/sch_atm.c 9 additions, 2 deletionsnet/sched/sch_atm.c
- net/sched/sch_cbq.c 21 additions, 18 deletionsnet/sched/sch_cbq.c
- net/sched/sch_tbf.c 1 addition, 1 deletionnet/sched/sch_tbf.c
Loading
Please register or sign in to comment