[NET]: Remove gratuitous use of skb->tail in network drivers.
Many drivers use skb->tail unnecessarily. In these situations, the code roughly looks like: dev = dev_alloc_skb(...); [optional] skb_reserve(skb, ...); ... skb->tail ... But even if the skb_reserve() happens, skb->data equals skb->tail. So it doesn't make any sense to use anything other than skb->data in these cases. Another case was the s2io.c driver directly mucking with the skb->data and skb->tail pointers. It really just wanted to do an skb_reserve(), so that's what the code was changed to do instead. Another reason I'm making this change as it allows some SKB cleanups I have planned simpler to merge. In those cleanups, skb->head, skb->tail, and skb->end pointers are removed, and replaced with skb->head_room and skb->tail_room integers. Signed-off-by:David S. Miller <davem@davemloft.net> Acked-by:
Jeff Garzik <jgarzik@pobox.com>
Showing
- drivers/net/3c515.c 2 additions, 2 deletionsdrivers/net/3c515.c
- drivers/net/3c59x.c 3 additions, 3 deletionsdrivers/net/3c59x.c
- drivers/net/8139cp.c 2 additions, 2 deletionsdrivers/net/8139cp.c
- drivers/net/82596.c 7 additions, 7 deletionsdrivers/net/82596.c
- drivers/net/dl2k.c 4 additions, 4 deletionsdrivers/net/dl2k.c
- drivers/net/eepro100.c 4 additions, 4 deletionsdrivers/net/eepro100.c
- drivers/net/epic100.c 3 additions, 3 deletionsdrivers/net/epic100.c
- drivers/net/fealnx.c 4 additions, 4 deletionsdrivers/net/fealnx.c
- drivers/net/hamachi.c 6 additions, 6 deletionsdrivers/net/hamachi.c
- drivers/net/lance.c 1 addition, 1 deletiondrivers/net/lance.c
- drivers/net/lasi_82596.c 4 additions, 4 deletionsdrivers/net/lasi_82596.c
- drivers/net/natsemi.c 2 additions, 2 deletionsdrivers/net/natsemi.c
- drivers/net/ns83820.c 2 additions, 2 deletionsdrivers/net/ns83820.c
- drivers/net/pcnet32.c 3 additions, 3 deletionsdrivers/net/pcnet32.c
- drivers/net/r8169.c 2 additions, 2 deletionsdrivers/net/r8169.c
- drivers/net/s2io.c 3 additions, 5 deletionsdrivers/net/s2io.c
- drivers/net/sb1250-mac.c 2 additions, 2 deletionsdrivers/net/sb1250-mac.c
- drivers/net/sis900.c 3 additions, 3 deletionsdrivers/net/sis900.c
- drivers/net/starfire.c 3 additions, 3 deletionsdrivers/net/starfire.c
- drivers/net/sundance.c 3 additions, 3 deletionsdrivers/net/sundance.c
Loading
Please register or sign in to comment