-
- Downloads
Rationalize fasync return values
Most fasync implementations do something like:
return fasync_helper(...);
But fasync_helper() will return a positive value at times - a feature used
in at least one place. Thus, a number of other drivers do:
err = fasync_helper(...);
if (err < 0)
return err;
return 0;
In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by:
Jonathan Corbet <corbet@lwn.net>
Showing
- drivers/char/sonypi.c 1 addition, 6 deletionsdrivers/char/sonypi.c
- drivers/gpu/drm/drm_fops.c 1 addition, 5 deletionsdrivers/gpu/drm/drm_fops.c
- drivers/hid/usbhid/hiddev.c 1 addition, 4 deletionsdrivers/hid/usbhid/hiddev.c
- drivers/ieee1394/dv1394.c 1 addition, 5 deletionsdrivers/ieee1394/dv1394.c
- drivers/input/evdev.c 1 addition, 4 deletionsdrivers/input/evdev.c
- drivers/input/joydev.c 1 addition, 4 deletionsdrivers/input/joydev.c
- drivers/input/mousedev.c 1 addition, 4 deletionsdrivers/input/mousedev.c
- drivers/input/serio/serio_raw.c 1 addition, 3 deletionsdrivers/input/serio/serio_raw.c
- drivers/net/wan/cosa.c 2 additions, 2 deletionsdrivers/net/wan/cosa.c
- drivers/platform/x86/sony-laptop.c 1 addition, 6 deletionsdrivers/platform/x86/sony-laptop.c
- drivers/scsi/sg.c 1 addition, 3 deletionsdrivers/scsi/sg.c
- fs/fcntl.c 2 additions, 0 deletionsfs/fcntl.c
- fs/ioctl.c 1 addition, 1 deletionfs/ioctl.c
- fs/pipe.c 3 additions, 13 deletionsfs/pipe.c
- sound/core/control.c 2 additions, 5 deletionssound/core/control.c
- sound/core/pcm_native.c 1 addition, 3 deletionssound/core/pcm_native.c
- sound/core/timer.c 1 addition, 5 deletionssound/core/timer.c
Loading
Please register or sign in to comment