Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
X
xcap-capability-linux
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Model registry
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
xcap
xcap-capability-linux
Commits
6071239e
Commit
6071239e
authored
16 years ago
by
Jonathan Corbet
Browse files
Options
Downloads
Patches
Plain Diff
mtdchar: cdev lock_kernel() pushdown
Signed-off-by:
Jonathan Corbet
<
corbet@lwn.net
>
parent
ea2959a2
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
drivers/mtd/mtdchar.c
+16
-6
16 additions, 6 deletions
drivers/mtd/mtdchar.c
with
16 additions
and
6 deletions
drivers/mtd/mtdchar.c
+
16
−
6
View file @
6071239e
...
...
@@ -14,6 +14,7 @@
#include
<linux/module.h>
#include
<linux/slab.h>
#include
<linux/sched.h>
#include
<linux/smp_lock.h>
#include
<linux/mtd/mtd.h>
#include
<linux/mtd/compatmac.h>
...
...
@@ -86,6 +87,7 @@ static int mtd_open(struct inode *inode, struct file *file)
{
int
minor
=
iminor
(
inode
);
int
devnum
=
minor
>>
1
;
int
ret
=
0
;
struct
mtd_info
*
mtd
;
struct
mtd_file_info
*
mfi
;
...
...
@@ -98,31 +100,39 @@ static int mtd_open(struct inode *inode, struct file *file)
if
((
file
->
f_mode
&
2
)
&&
(
minor
&
1
))
return
-
EACCES
;
lock_kernel
();
mtd
=
get_mtd_device
(
NULL
,
devnum
);
if
(
IS_ERR
(
mtd
))
return
PTR_ERR
(
mtd
);
if
(
IS_ERR
(
mtd
))
{
ret
=
PTR_ERR
(
mtd
);
goto
out
;
}
if
(
MTD_ABSENT
==
mtd
->
type
)
{
put_mtd_device
(
mtd
);
return
-
ENODEV
;
ret
=
-
ENODEV
;
goto
out
;
}
/* You can't open it RW if it's not a writeable device */
if
((
file
->
f_mode
&
2
)
&&
!
(
mtd
->
flags
&
MTD_WRITEABLE
))
{
put_mtd_device
(
mtd
);
return
-
EACCES
;
ret
=
-
EACCES
;
goto
out
;
}
mfi
=
kzalloc
(
sizeof
(
*
mfi
),
GFP_KERNEL
);
if
(
!
mfi
)
{
put_mtd_device
(
mtd
);
return
-
ENOMEM
;
ret
=
-
ENOMEM
;
goto
out
;
}
mfi
->
mtd
=
mtd
;
file
->
private_data
=
mfi
;
return
0
;
out:
unlock_kernel
();
return
ret
;
}
/* mtd_open */
/*====================================================================*/
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment