Commit 5ebf6e6a authored by Jeff Garzik's avatar Jeff Garzik Committed by Anton Vorontsov

pda_power: clean up irq, timer

Clean up pda_power interrupt handling:

Prior to this patch, the driver would pass information it needed
to the interrupt handler dev_id pointer, and then prompt forget it
ever did so, recreating that same information after a couple passes
through the timer-based state machine.

This patch removes the redundant checks by passing the
pda_power_supply[] pointer through the state machine.  The current
code passed 'irq' through the state machine, as an index to recreate
the pointer, when we could more simply pass around the pointer itself.

This patch makes it easier to remove the 'irq' argument in the future,
in addition to cleaning up the driver today.
Signed-off-by: default avatarJeff Garzik <>
parent 3be86148
......@@ -101,32 +101,31 @@ static void update_charger(void)
static void supply_timer_func(unsigned long irq)
static void supply_timer_func(unsigned long power_supply_ptr)
if (ac_irq && irq == ac_irq->start)
else if (usb_irq && irq == usb_irq->start)
void *power_supply = (void *)power_supply_ptr;
static void charger_timer_func(unsigned long irq)
static void charger_timer_func(unsigned long power_supply_ptr)
/* Okay, charger set. Now wait a bit before notifying supplicants,
* charge power should stabilize. */ = irq; = power_supply_ptr;
jiffies + msecs_to_jiffies(pdata->wait_for_charger));
static irqreturn_t power_changed_isr(int irq, void *unused)
static irqreturn_t power_changed_isr(int irq, void *power_supply)
/* Wait a bit before reading ac/usb line status and setting charger,
* because ac/usb status readings may lag from irq. */ = irq; = (unsigned long)power_supply;
jiffies + msecs_to_jiffies(pdata->wait_for_status));
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment