-
- Downloads
[PATCH] cfag12864b: fix crash when built-in and no parport present
The problem comes when ks0108/cfag12864b are built-in and no parallel port is present. ks0108_init() is called first, as it should be, but fails to load (as there is no parallel port to use). After that, cfag12864b_init() gets called, without knowing anything about ks0108 failed, and calls ks0108_writecontrol(), which dereferences an uninitialized pointer. Init order is OK, I think. The problem is how to stop cfag12864b_init() being called if ks0108 failed to load. modprobe does it for us, but, how when built-in? Signed-off-by:Miguel Ojeda Sandonis <maxextreme@gmail.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- drivers/auxdisplay/cfag12864b.c 19 additions, 0 deletionsdrivers/auxdisplay/cfag12864b.c
- drivers/auxdisplay/cfag12864bfb.c 9 additions, 1 deletiondrivers/auxdisplay/cfag12864bfb.c
- drivers/auxdisplay/ks0108.c 12 additions, 0 deletionsdrivers/auxdisplay/ks0108.c
- include/linux/cfag12864b.h 5 additions, 0 deletionsinclude/linux/cfag12864b.h
- include/linux/ks0108.h 3 additions, 0 deletionsinclude/linux/ks0108.h
Loading
Please register or sign in to comment